public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Fix gdb.arch/aarch64-dbreg-contents.exp build failures
@ 2020-02-28 15:20 Luis Machado
0 siblings, 0 replies; only message in thread
From: Luis Machado @ 2020-02-28 15:20 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=718e081605e86b7421afc1b3ab2e4918292dd254
commit 718e081605e86b7421afc1b3ab2e4918292dd254
Author: Luis Machado <luis.machado@linaro.org>
Date: Tue Feb 25 10:09:19 2020 -0300
Fix gdb.arch/aarch64-dbreg-contents.exp build failures
I ran into the following failures when running tests under QEMU:
--
gdb compile failed, binutils-gdb/gdb/testsuite/gdb.arch/aarch64-dbreg-contents.c: In function 'set_watchpoint':
binutils-gdb/gdb/testsuite/gdb.arch/aarch64-dbreg-contents.c:41:29: error: storage size of 'dreg_state' isn't known
struct user_hwdebug_state dreg_state;
^~~~~~~~~~
In file included from /usr/include/aarch64-linux-gnu/bits/types/struct_iovec.h:23:0,
from /usr/include/aarch64-linux-gnu/sys/uio.h:23,
from binutils-gdb/gdb/testsuite/gdb.arch/aarch64-dbreg-contents.c:17:
binutils-gdb/gdb/testsuite/gdb.arch/aarch64-dbreg-contents.c:69:18: error: invalid use of undefined type 'struct user_hwdebug_state'
iov.iov_len = (offsetof (struct user_hwdebug_state, dbg_regs)
^
binutils-gdb/gdb/testsuite/gdb.arch/aarch64-dbreg-contents.c:74:5: warning: implicit declaration of function 'error'; did you mean 'errno'? [-Wimplicit-function-declaration]
error (1, errno, "PTRACE_SETREGSET: NT_ARM_HW_WATCH");
^~~~~
errno
binutils-gdb/gdb/testsuite/gdb.arch/aarch64-dbreg-contents.c: In function 'main':
binutils-gdb/gdb/testsuite/gdb.arch/aarch64-dbreg-contents.c:87:3: warning: implicit declaration of function 'atexit'; did you mean '_Exit'? [-Wimplicit-function-declaration]
atexit (cleanup);
^~~~~~
_Exit
binutils-gdb/gdb/testsuite/gdb.arch/aarch64-dbreg-contents.c:89:11: warning: implicit declaration of function 'fork' [-Wimplicit-function-declaration]
child = fork ();
^~~~
--
The following patch fixes those by adding the necessary include files.
With that said, the test doesn't pass at present. I'll have to investigate it
a bit more.
gdb/testsuite/ChangeLog:
2020-02-28 Luis Machado <luis.machado@linaro.org>
* gdb.arch/aarch64-dbreg-contents.c: Include stdlib.h, unistd,
asm/ptrace.h and error.h.
Diff:
---
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/gdb.arch/aarch64-dbreg-contents.c | 4 ++++
2 files changed, 9 insertions(+)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 70bee9c..c3f49e0 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2020-02-28 Luis Machado <luis.machado@linaro.org>
+
+ * gdb.arch/aarch64-dbreg-contents.c: Include stdlib.h, unistd.h,
+ asm/ptrace.h and error.h.
+
2020-02-28 Tom de Vries <tdevries@suse.de>
* gdb.base/c-linkage-name.c (main): Call do_something_other_cu.
diff --git a/gdb/testsuite/gdb.arch/aarch64-dbreg-contents.c b/gdb/testsuite/gdb.arch/aarch64-dbreg-contents.c
index 66ca76f..ca690f6 100644
--- a/gdb/testsuite/gdb.arch/aarch64-dbreg-contents.c
+++ b/gdb/testsuite/gdb.arch/aarch64-dbreg-contents.c
@@ -9,13 +9,17 @@
freely. */
#define _GNU_SOURCE 1
+#include <stdlib.h>
+#include <unistd.h>
#include <sys/ptrace.h>
+#include <asm/ptrace.h>
#include <assert.h>
#include <sys/wait.h>
#include <stddef.h>
#include <errno.h>
#include <sys/uio.h>
#include <elf.h>
+#include <error.h>
static pid_t child;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-02-28 15:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-28 15:20 [binutils-gdb] Fix gdb.arch/aarch64-dbreg-contents.exp build failures Luis Machado
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).