public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Fix comment for 'gdb_dlopen'
@ 2020-02-28 16:05 Sergio Durigan Junior
0 siblings, 0 replies; only message in thread
From: Sergio Durigan Junior @ 2020-02-28 16:05 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d7592e974706637058867b02626c52a30ef0a2ee
commit d7592e974706637058867b02626c52a30ef0a2ee
Author: Sergio Durigan Junior <sergiodj@redhat.com>
Date: Tue Feb 25 15:50:16 2020 -0500
Fix comment for 'gdb_dlopen'
The 'gdb_dlopen' function doesn't return NULL if the shlib load
fails; it actually throws an error. This patch updates the comment
to reflect this.
gdbsupport/ChangeLog:
2020-02-28 Sergio Durigan Junior <sergiodj@redhat.com>
* gdb-dlfcn.h (gdb_dlopen): Update comment.
Diff:
---
gdbsupport/ChangeLog | 4 ++++
gdbsupport/gdb-dlfcn.h | 4 ++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/gdbsupport/ChangeLog b/gdbsupport/ChangeLog
index d01966e..88f2b82 100644
--- a/gdbsupport/ChangeLog
+++ b/gdbsupport/ChangeLog
@@ -1,3 +1,7 @@
+2020-02-28 Sergio Durigan Junior <sergiodj@redhat.com>
+
+ * gdb-dlfcn.h (gdb_dlopen): Update comment.
+
2020-02-19 Andrew Burgess <andrew.burgess@embecosm.com>
* configure: Regenerate.
diff --git a/gdbsupport/gdb-dlfcn.h b/gdbsupport/gdb-dlfcn.h
index 258cfeb..9e72a53 100644
--- a/gdbsupport/gdb-dlfcn.h
+++ b/gdbsupport/gdb-dlfcn.h
@@ -32,8 +32,8 @@ struct dlclose_deleter
typedef std::unique_ptr<void, dlclose_deleter> gdb_dlhandle_up;
/* Load the dynamic library file named FILENAME, and return a handle
- for that dynamic library. Return NULL if the loading fails for any
- reason. */
+ for that dynamic library. Throw an error if the loading fails for
+ any reason. */
gdb_dlhandle_up gdb_dlopen (const char *filename);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-02-28 16:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-28 16:05 [binutils-gdb] Fix comment for 'gdb_dlopen' Sergio Durigan Junior
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).