public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Don't try to get the TIB address without an inferior
@ 2020-03-06 17:40 Hannes Domani
  0 siblings, 0 replies; only message in thread
From: Hannes Domani @ 2020-03-06 17:40 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b7d64b29094ef58448c9b41bcde299fad2976237

commit b7d64b29094ef58448c9b41bcde299fad2976237
Author: Hannes Domani <ssbssa@yahoo.de>
Date:   Wed Mar 4 21:20:31 2020 +0100

    Don't try to get the TIB address without an inferior
    
    The target_get_tib_address call always fails in this case, and there is an
    error when changing the program with the file command:
    
    (gdb) file allocer64.exe
    Reading symbols from allocer64.exe...
    You can't do that when your target is `exec'
    
    Now it will skip this part, there is no need to rebase the executable without
    an inferior anyways.
    
    gdb/ChangeLog:
    
    2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
    
    	* windows-tdep.c (windows_solib_create_inferior_hook):
    	Check if inferior is running.

Diff:
---
 gdb/ChangeLog      | 5 +++++
 gdb/windows-tdep.c | 3 ++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 0e053e2..9c2e68d 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
+
+	* windows-tdep.c (windows_solib_create_inferior_hook):
+	Check if inferior is running.
+
 2020-03-06  Tom de Vries  <tdevries@suse.de>
 
 	* NEWS: Fix "the the".
diff --git a/gdb/windows-tdep.c b/gdb/windows-tdep.c
index 4e5d830..e02b1ce 100644
--- a/gdb/windows-tdep.c
+++ b/gdb/windows-tdep.c
@@ -843,7 +843,8 @@ windows_solib_create_inferior_hook (int from_tty)
     }
   CORE_ADDR tlb;
   gdb_byte buf[8];
-  if (target_get_tib_address (inferior_ptid, &tlb)
+  if (target_has_execution
+      && target_get_tib_address (inferior_ptid, &tlb)
       && !target_read_memory (tlb + peb_offset, buf, ptr_bytes))
     {
       CORE_ADDR peb = extract_unsigned_integer (buf, ptr_bytes, byte_order);


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-03-06 17:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-06 17:40 [binutils-gdb] Don't try to get the TIB address without an inferior Hannes Domani

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).