public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Remove some obsolete comments
Date: Sat, 7 Mar 2020 15:03:41 +0000 (GMT) [thread overview]
Message-ID: <20200307150341.153DD3937435@server2.sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e8932576355851be8bac0b0b86a3be4f2005e47f
commit e8932576355851be8bac0b0b86a3be4f2005e47f
Author: Tom Tromey <tom@tromey.com>
Date: Sat Mar 7 07:53:42 2020 -0700
Remove some obsolete comments
While working on complex number support, I found a couple of
apparently obsolete coments. This removes them.
2020-03-07 Tom Tromey <tom@tromey.com>
* valops.c (value_literal_complex): Remove obsolete comment.
* gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
comment.
Diff:
---
gdb/ChangeLog | 6 ++++++
gdb/gdbtypes.h | 4 +---
gdb/valops.c | 4 +---
3 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 0de37948a08..9a25504faaf 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2020-03-07 Tom Tromey <tom@tromey.com>
+
+ * valops.c (value_literal_complex): Remove obsolete comment.
+ * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
+ comment.
+
2020-03-06 Simon Marchi <simon.marchi@polymtl.ca>
* infrun.h: Forward-declare thread_info.
diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
index 74498435822..cb674dbc1e8 100644
--- a/gdb/gdbtypes.h
+++ b/gdb/gdbtypes.h
@@ -120,9 +120,7 @@ enum type_code
TYPE_CODE_FUNC, /**< Function type */
TYPE_CODE_INT, /**< Integer type */
- /* * Floating type. This is *NOT* a complex type. Beware, there
- are parts of GDB which bogusly assume that TYPE_CODE_FLT can
- mean complex. */
+ /* * Floating type. This is *NOT* a complex type. */
TYPE_CODE_FLT,
/* * Void type. The length field specifies the length (probably
diff --git a/gdb/valops.c b/gdb/valops.c
index 7fc555a8108..d48474665c3 100644
--- a/gdb/valops.c
+++ b/gdb/valops.c
@@ -3856,9 +3856,7 @@ value_slice (struct value *array, int lowbound, int length)
/* Create a value for a FORTRAN complex number. Currently most of the
time values are coerced to COMPLEX*16 (i.e. a complex number
- composed of 2 doubles. This really should be a smarter routine
- that figures out precision intelligently as opposed to assuming
- doubles. FIXME: fmb */
+ composed of 2 doubles. */
struct value *
value_literal_complex (struct value *arg1,
reply other threads:[~2020-03-07 15:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200307150341.153DD3937435@server2.sourceware.org \
--to=tromey@sourceware.org \
--cc=gdb-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).