From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1879) id A976139450FC; Wed, 11 Mar 2020 19:15:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A976139450FC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1583954148; bh=dMgKhii2eUvVjlHEu/HWj9velbfbuEmBf+/SgWKTRRk=; h=From:To:Subject:Date:From; b=TTmrgKSXoxheVwddTTRQqQT9kzTqjmtQAqC/KOy6ngKDeq3C6dWecJdL0jpMv7ScV Fvpdmhei2olU8dWC+40jB48S9ZoX0GFentv2laT7d92Gdbku65KOMZPCyLz2SViDK9 ivEOSl8zkgYFB+hZQIImuPeDGOX95sCYPLXnj+UQ= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Simon Marchi To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb: enable -Wmissing-prototypes warning X-Act-Checkin: binutils-gdb X-Git-Author: Simon Marchi X-Git-Refname: refs/heads/master X-Git-Oldrev: 5308d1e77167b4bb133302d7a6f66e599abee420 X-Git-Newrev: a0761e34f054767de6d6389929d27e9015fb299b Message-Id: <20200311191548.A976139450FC@sourceware.org> Date: Wed, 11 Mar 2020 19:15:48 +0000 (GMT) X-BeenThere: gdb-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Mar 2020 19:15:48 -0000 https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a0761e34f054767de6d6389929d27e9015fb299b commit a0761e34f054767de6d6389929d27e9015fb299b Author: Simon Marchi Date: Wed Mar 11 15:15:12 2020 -0400 gdb: enable -Wmissing-prototypes warning While compiling with clang, I noticed it didn't catch cases where my function declaration didn't match my function definition. This is normally caught by gcc with -Wmissing-declarations. On clang, this is caught by -Wmissing-prototypes instead. Note that on gcc, -Wmissing-prototypes also exists, but is only valid for C and Objective-C. It gets correctly rejected by the configure script since gcc rejects it with: cc1plus: error: command line option '-Wmissing-prototypes' is valid for C/ObjC but not for C++ -Werror So this warning flag ends up not used for gcc (which is what we want). gdb/ChangeLog: * configure: Re-generate. gdbserver/ChangeLog: * configure: Re-generate. gdbsupport/ChangeLog: * configure: Re-generate. * warning.m4: Enable -Wmissing-prototypes. Diff: --- gdb/ChangeLog | 4 ++++ gdb/configure | 1 + gdbserver/ChangeLog | 4 ++++ gdbserver/configure | 1 + gdbsupport/ChangeLog | 5 +++++ gdbsupport/configure | 1 + gdbsupport/warning.m4 | 1 + 7 files changed, 17 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 465bef0d29f..e8fc63cc25a 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2020-03-11 Simon Marchi + + * configure: Re-generate. + 2020-03-11 Tom Tromey * ada-typeprint.c (print_choices): Fix comment. diff --git a/gdb/configure b/gdb/configure index f99cbe40f11..47ca77f400c 100755 --- a/gdb/configure +++ b/gdb/configure @@ -16323,6 +16323,7 @@ build_warnings="-Wall -Wpointer-arith \ -Wdeprecated-copy-dtor \ -Wredundant-move \ -Wmissing-declarations \ +-Wmissing-prototypes \ -Wstrict-null-sentinel \ " diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog index 16346de8dec..ef8addbfe87 100644 --- a/gdbserver/ChangeLog +++ b/gdbserver/ChangeLog @@ -1,3 +1,7 @@ +2020-03-11 Simon Marchi + + * configure: Re-generate. + 2020-03-06 Andrew Burgess * .dir-locals.el: New file. diff --git a/gdbserver/configure b/gdbserver/configure index be5719eb77a..13ac7188454 100755 --- a/gdbserver/configure +++ b/gdbserver/configure @@ -9616,6 +9616,7 @@ build_warnings="-Wall -Wpointer-arith \ -Wdeprecated-copy-dtor \ -Wredundant-move \ -Wmissing-declarations \ +-Wmissing-prototypes \ -Wstrict-null-sentinel \ " diff --git a/gdbsupport/ChangeLog b/gdbsupport/ChangeLog index 0fbb71d9e56..f9fe58a7f59 100644 --- a/gdbsupport/ChangeLog +++ b/gdbsupport/ChangeLog @@ -1,3 +1,8 @@ +2020-03-11 Simon Marchi + + * configure: Re-generate. + * warning.m4: Enable -Wmissing-prototypes. + 2020-03-08 Tom Tromey * gdb_binary_search.h: Fix two typos. diff --git a/gdbsupport/configure b/gdbsupport/configure index e7a99e3ddfb..1b141387e5a 100755 --- a/gdbsupport/configure +++ b/gdbsupport/configure @@ -10874,6 +10874,7 @@ build_warnings="-Wall -Wpointer-arith \ -Wdeprecated-copy-dtor \ -Wredundant-move \ -Wmissing-declarations \ +-Wmissing-prototypes \ -Wstrict-null-sentinel \ " diff --git a/gdbsupport/warning.m4 b/gdbsupport/warning.m4 index 81939ed7610..649be7552dd 100644 --- a/gdbsupport/warning.m4 +++ b/gdbsupport/warning.m4 @@ -51,6 +51,7 @@ build_warnings="-Wall -Wpointer-arith \ -Wdeprecated-copy-dtor \ -Wredundant-move \ -Wmissing-declarations \ +-Wmissing-prototypes \ -Wstrict-null-sentinel \ "