public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Rewrite nbsd_nat_target::pid_to_exec_file to sysctl(3)
@ 2020-03-17 9:23 Kamil Rytarowski
0 siblings, 0 replies; only message in thread
From: Kamil Rytarowski @ 2020-03-17 9:23 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a2ecbe9fb7355698aad97841f9717cdfd7096d95
commit a2ecbe9fb7355698aad97841f9717cdfd7096d95
Author: Kamil Rytarowski <n54@gmx.com>
Date: Sun Mar 15 00:12:53 2020 +0100
Rewrite nbsd_nat_target::pid_to_exec_file to sysctl(3)
procfs on NetBSD is optional and not recommended.
* nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
<sys/sysctl.h>.
* nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
Diff:
---
gdb/ChangeLog | 6 ++++++
gdb/nbsd-nat.c | 22 ++++++++++------------
2 files changed, 16 insertions(+), 12 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 3c9215060a9..cb2e91be8d0 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2020-03-17 Kamil Rytarowski <n54@gmx.com>
+
+ * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
+ <sys/sysctl.h>.
+ * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
+
2020-03-17 Tom de Vries <tdevries@suse.de>
PR gdb/23710
diff --git a/gdb/nbsd-nat.c b/gdb/nbsd-nat.c
index e7f91bebb0d..326bbe3aec3 100644
--- a/gdb/nbsd-nat.c
+++ b/gdb/nbsd-nat.c
@@ -21,23 +21,21 @@
#include "nbsd-nat.h"
+#include <sys/types.h>
+#include <sys/ptrace.h>
+#include <sys/sysctl.h>
+
/* Return the name of a file that can be opened to get the symbols for
the child process identified by PID. */
char *
nbsd_nat_target::pid_to_exec_file (int pid)
{
- ssize_t len;
static char buf[PATH_MAX];
- char name[PATH_MAX];
-
- xsnprintf (name, PATH_MAX, "/proc/%d/exe", pid);
- len = readlink (name, buf, PATH_MAX - 1);
- if (len != -1)
- {
- buf[len] = '\0';
- return buf;
- }
-
- return NULL;
+ size_t buflen;
+ int mib[4] = {CTL_KERN, KERN_PROC_ARGS, pid, KERN_PROC_PATHNAME};
+ buflen = sizeof (buf);
+ if (sysctl (mib, ARRAY_SIZE (mib), buf, &buflen, NULL, 0))
+ return NULL;
+ return buf;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-03-17 9:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-17 9:23 [binutils-gdb] Rewrite nbsd_nat_target::pid_to_exec_file to sysctl(3) Kamil Rytarowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).