From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id EE479385E01D; Sat, 28 Mar 2020 15:27:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EE479385E01D Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Fix comment in dwarf2/attribute.h X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: f1749218ff325e2074583fa7d7caf9ee09a1feb8 X-Git-Newrev: 4d1b9ab645d9ce72aad15011264dd9b2e52a57e8 Message-Id: <20200328152701.EE479385E01D@sourceware.org> Date: Sat, 28 Mar 2020 15:27:01 +0000 (GMT) X-BeenThere: gdb-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Mar 2020 15:27:02 -0000 https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4d1b9ab645d9ce72aad15011264dd9b2e52a57e8 commit 4d1b9ab645d9ce72aad15011264dd9b2e52a57e8 Author: Tom Tromey Date: Sat Mar 28 09:25:41 2020 -0600 Fix comment in dwarf2/attribute.h I noticed that a comment in dwarf2/attribute.h still referred to dwarf2_get_attr_constant_value. However, this is now a method on struct attribute. gdb/ChangeLog 2020-03-28 Tom Tromey * dwarf2/attribute.h (struct attribute) : Update comment. Diff: --- gdb/ChangeLog | 5 +++++ gdb/dwarf2/attribute.h | 6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index bc4451ec0c4..82ece136367 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2020-03-28 Tom Tromey + + * dwarf2/attribute.h (struct attribute) : Update + comment. + 2020-03-28 Tom Tromey * dwarf2/read.c (read_attribute_reprocess): Fix formatting. diff --git a/gdb/dwarf2/attribute.h b/gdb/dwarf2/attribute.h index 483b805433b..69b33513ad6 100644 --- a/gdb/dwarf2/attribute.h +++ b/gdb/dwarf2/attribute.h @@ -59,7 +59,7 @@ struct attribute /* Return non-zero if ATTR's value falls in the 'constant' class, or zero otherwise. When this function returns true, you can apply - dwarf2_get_attr_constant_value to it. + the constant_value method to it. However, note that for some attributes you must check attr_form_is_section_offset before using this test. DW_FORM_data4 @@ -70,8 +70,8 @@ struct attribute section offset classes, DW_FORM_data4 and DW_FORM_data8 should be taken as section offsets, not constants. - DW_FORM_data16 is not considered as dwarf2_get_attr_constant_value - cannot handle that. */ + DW_FORM_data16 is not considered as constant_value cannot handle + that. */ bool form_is_constant () const;