From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id 876153948AA5; Wed, 8 Apr 2020 20:51:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 876153948AA5 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Introduce win32_target_ops::decr_pc_after_break X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: d6225aff7a4f11c3443515c0d8dad12351b97575 X-Git-Newrev: e54e59297a747bb4f396345aa090d43f155b5576 Message-Id: <20200408205136.876153948AA5@sourceware.org> Date: Wed, 8 Apr 2020 20:51:36 +0000 (GMT) X-BeenThere: gdb-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Apr 2020 20:51:36 -0000 https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e54e59297a747bb4f396345aa090d43f155b5576 commit e54e59297a747bb4f396345aa090d43f155b5576 Author: Tom Tromey Date: Wed Apr 8 14:33:35 2020 -0600 Introduce win32_target_ops::decr_pc_after_break This adds a decr_pc_after_break member to win32_target_ops and updates the two Windows targets to set it. Note that I can't test the win32-arm-low.c change. gdbserver/ChangeLog 2020-04-08 Tom Tromey * win32-low.h (struct win32_target_ops) : New field. * win32-i386-low.c (the_low_target): Update. * win32-arm-low.c (the_low_target): Update. Diff: --- gdbserver/ChangeLog | 7 +++++++ gdbserver/win32-arm-low.cc | 1 + gdbserver/win32-i386-low.cc | 1 + gdbserver/win32-low.h | 4 ++++ 4 files changed, 13 insertions(+) diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog index ee66a4b6d99..24c42e28d06 100644 --- a/gdbserver/ChangeLog +++ b/gdbserver/ChangeLog @@ -1,3 +1,10 @@ +2020-04-08 Tom Tromey + + * win32-low.h (struct win32_target_ops) : New + field. + * win32-i386-low.c (the_low_target): Update. + * win32-arm-low.c (the_low_target): Update. + 2020-04-08 Tom Tromey * win32-low.h (win32_process_target::read_pc) diff --git a/gdbserver/win32-arm-low.cc b/gdbserver/win32-arm-low.cc index 77200112df1..238ee4b05be 100644 --- a/gdbserver/win32-arm-low.cc +++ b/gdbserver/win32-arm-low.cc @@ -148,6 +148,7 @@ struct win32_target_ops the_low_target = { NULL, /* single_step */ (const unsigned char *) &arm_wince_breakpoint, arm_wince_breakpoint_len, + 0, arm_win32_get_pc, arm_win32_set_pc, /* Watchpoint related functions. See target.h for comments. */ diff --git a/gdbserver/win32-i386-low.cc b/gdbserver/win32-i386-low.cc index eac15b5694a..48893af33b2 100644 --- a/gdbserver/win32-i386-low.cc +++ b/gdbserver/win32-i386-low.cc @@ -506,6 +506,7 @@ struct win32_target_ops the_low_target = { i386_single_step, &i386_win32_breakpoint, i386_win32_breakpoint_len, + 1, i386_win32_get_pc, i386_win32_set_pc, i386_supports_z_point_type, diff --git a/gdbserver/win32-low.h b/gdbserver/win32-low.h index 56ff8a9baf2..d2b39a46fd9 100644 --- a/gdbserver/win32-low.h +++ b/gdbserver/win32-low.h @@ -63,6 +63,10 @@ struct win32_target_ops const unsigned char *breakpoint; int breakpoint_len; + /* Amount by which to decrement the PC after a breakpoint is + hit. */ + int decr_pc_after_break; + /* Get the PC register from REGCACHE. */ CORE_ADDR (*get_pc) (struct regcache *regcache); /* Set the PC register in REGCACHE. */