From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2023) id 20B2A385B835; Fri, 17 Apr 2020 03:53:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 20B2A385B835 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Kamil Rytarowski To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Remove obsolete and unused inf_ptrace_target::auxv_parse X-Act-Checkin: binutils-gdb X-Git-Author: Kamil Rytarowski X-Git-Refname: refs/heads/master X-Git-Oldrev: 49af2f5c83b1eed1e9eeecb7a2bba49fc60c4d64 X-Git-Newrev: 3557f442a1881271652581b4a66c206d5b348c5d Message-Id: <20200417035310.20B2A385B835@sourceware.org> Date: Fri, 17 Apr 2020 03:53:10 +0000 (GMT) X-BeenThere: gdb-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2020 03:53:10 -0000 https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3557f442a1881271652581b4a66c206d5b348c5d commit 3557f442a1881271652581b4a66c206d5b348c5d Author: Kamil Rytarowski Date: Wed Apr 15 21:32:08 2020 +0200 Remove obsolete and unused inf_ptrace_target::auxv_parse The only two potential users (NetBSD, OpenBSD) use svr4_auxv_parse. gdb/ChangeLog: * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove. * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise. Diff: --- gdb/ChangeLog | 5 +++++ gdb/inf-ptrace.c | 36 ------------------------------------ gdb/inf-ptrace.h | 5 ----- 3 files changed, 5 insertions(+), 41 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index c57ffe1a7b3..b03101c8cd9 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2020-04-16 Kamil Rytarowski + + * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove. + * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise. + 2020-04-16 Simon Marchi * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to diff --git a/gdb/inf-ptrace.c b/gdb/inf-ptrace.c index 1fa7aa3f73e..06d23ae457d 100644 --- a/gdb/inf-ptrace.c +++ b/gdb/inf-ptrace.c @@ -643,39 +643,3 @@ inf_ptrace_target::pid_to_str (ptid_t ptid) { return normal_pid_to_str (ptid); } - -#if defined (PT_IO) && defined (PIOD_READ_AUXV) - -/* Read one auxv entry from *READPTR, not reading locations >= ENDPTR. - Return 0 if *READPTR is already at the end of the buffer. - Return -1 if there is insufficient buffer for a whole entry. - Return 1 if an entry was read into *TYPEP and *VALP. */ - -int -inf_ptrace_target::auxv_parse (gdb_byte **readptr, gdb_byte *endptr, - CORE_ADDR *typep, CORE_ADDR *valp) -{ - struct type *int_type = builtin_type (target_gdbarch ())->builtin_int; - struct type *ptr_type = builtin_type (target_gdbarch ())->builtin_data_ptr; - const int sizeof_auxv_type = TYPE_LENGTH (int_type); - const int sizeof_auxv_val = TYPE_LENGTH (ptr_type); - enum bfd_endian byte_order = gdbarch_byte_order (target_gdbarch ()); - gdb_byte *ptr = *readptr; - - if (endptr == ptr) - return 0; - - if (endptr - ptr < 2 * sizeof_auxv_val) - return -1; - - *typep = extract_unsigned_integer (ptr, sizeof_auxv_type, byte_order); - ptr += sizeof_auxv_val; /* Alignment. */ - *valp = extract_unsigned_integer (ptr, sizeof_auxv_val, byte_order); - ptr += sizeof_auxv_val; - - *readptr = ptr; - return 1; -} - -#endif - diff --git a/gdb/inf-ptrace.h b/gdb/inf-ptrace.h index 05c1277ec4e..2178b1baab7 100644 --- a/gdb/inf-ptrace.h +++ b/gdb/inf-ptrace.h @@ -68,11 +68,6 @@ struct inf_ptrace_target : public inf_child_target ULONGEST offset, ULONGEST len, ULONGEST *xfered_len) override; -#if defined (PT_IO) && defined (PIOD_READ_AUXV) - int auxv_parse (gdb_byte **readptr, - gdb_byte *endptr, CORE_ADDR *typep, CORE_ADDR *valp) override; -#endif - protected: /* Cleanup the inferior after a successful ptrace detach. */ void detach_success (inferior *inf);