public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Kamil Rytarowski <krytarowski@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Fix gdb.base/attach-twice.c build on NetBSD Date: Fri, 17 Apr 2020 22:20:22 +0000 (GMT) [thread overview] Message-ID: <20200417222022.F004D385B835@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4ddfec930ca5bd57800ebc71daef66f685a6de4d commit 4ddfec930ca5bd57800ebc71daef66f685a6de4d Author: Kamil Rytarowski <n54@gmx.com> Date: Fri Apr 17 18:39:42 2020 +0200 Fix gdb.base/attach-twice.c build on NetBSD Add a fallback definition of PTRACE_ATTACH that is an alias of PT_ATTACH. Change the 4th argument of ptrace(2) to 0 as it is compatible with void * (Linux) and int (NetBSD) arguments. Include <sys/types.h> for <sys/ptrace.h>. gdb/testsuite/ChangeLog: * gdb.base/attach-twice.c: Include "sys/types.h". (PTRACE_ATTACH): Add fallback definition. (main): Pass `0' to the 4th argument of `ptrace'. Diff: --- gdb/testsuite/ChangeLog | 6 ++++++ gdb/testsuite/gdb.base/attach-twice.c | 9 ++++++++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 44ada371679..b24efc772b2 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2020-04-17 Kamil Rytarowski <n54@gmx.com> + + * gdb.base/attach-twice.c: Include "sys/types.h". + (PTRACE_ATTACH): Add fallback definition. + (main): Pass `0' to the 4th argument of `ptrace'. + 2020-04-17 Kamil Rytarowski <n54@gmx.com> * gdb.base/fork-running-state.c: Include "signal.h". diff --git a/gdb/testsuite/gdb.base/attach-twice.c b/gdb/testsuite/gdb.base/attach-twice.c index 9299b3abf81..31cd087453f 100644 --- a/gdb/testsuite/gdb.base/attach-twice.c +++ b/gdb/testsuite/gdb.base/attach-twice.c @@ -18,9 +18,14 @@ #include <stdio.h> #include <stdlib.h> #include <unistd.h> +#include <sys/types.h> #include <sys/ptrace.h> #include <errno.h> +#ifndef PTRACE_ATTACH +#define PTRACE_ATTACH PT_ATTACH +#endif + int main (void) { @@ -33,7 +38,9 @@ main (void) exit (1); case 0: errno = 0; - ptrace (PTRACE_ATTACH, getppid (), NULL, NULL); + /* The 4th argument to ptrace () is 0 on purpose, as it is compatible + between kernels that accept void* (like Linux) and int (NetBSD). */ + ptrace (PTRACE_ATTACH, getppid (), NULL, 0); if (errno != 0) perror ("PTRACE_ATTACH"); break;
reply other threads:[~2020-04-17 22:20 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200417222022.F004D385B835@sourceware.org \ --to=krytarowski@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).