public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] [gdb/testsuite] Add xfails for PR gcc/90232 Date: Wed, 29 Apr 2020 11:22:24 +0000 (GMT) [thread overview] Message-ID: <20200429112224.67C1238930D0@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=6e4e3fe1b6d68bde1f4e022bd0675fe36420e976 commit 6e4e3fe1b6d68bde1f4e022bd0675fe36420e976 Author: Tom de Vries <tdevries@suse.de> Date: Wed Apr 29 13:22:21 2020 +0200 [gdb/testsuite] Add xfails for PR gcc/90232 With target board debug-types, we have these FAILs: ... FAIL: gdb.guile/scm-symtab.exp: test simple_struct in static symbols FAIL: gdb.python/py-symtab.exp: test simple_struct in static symbols ... due to PR gcc/90232, as explained in commit 15cd93d05e8 "[gdb/symtab] Handle struct decl with DW_AT_signature". Marks these as XFAILs. Tested on x86_64-linux. gdb/testsuite/ChangeLog: 2020-04-29 Tom de Vries <tdevries@suse.de> * lib/gdb.exp (debug_types): New proc. * gdb.guile/scm-symtab.exp: Add xfail for PR gcc/90232. * gdb.python/py-symtab.exp: Same. Diff: --- gdb/testsuite/ChangeLog | 6 ++++++ gdb/testsuite/gdb.guile/scm-symtab.exp | 19 +++++++++++++++++-- gdb/testsuite/gdb.python/py-symtab.exp | 17 ++++++++++++++++- gdb/testsuite/lib/gdb.exp | 18 ++++++++++++++++++ 4 files changed, 57 insertions(+), 3 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 86b71913b01..299bb790c52 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2020-04-29 Tom de Vries <tdevries@suse.de> + + * lib/gdb.exp (debug_types): New proc. + * gdb.guile/scm-symtab.exp: Add xfail for PR gcc/90232. + * gdb.python/py-symtab.exp: Same. + 2020-04-29 Hannes Domani <ssbssa@yahoo.de> PR gdb/17320 diff --git a/gdb/testsuite/gdb.guile/scm-symtab.exp b/gdb/testsuite/gdb.guile/scm-symtab.exp index 4b8c15566ed..b6d5a719437 100644 --- a/gdb/testsuite/gdb.guile/scm-symtab.exp +++ b/gdb/testsuite/gdb.guile/scm-symtab.exp @@ -32,6 +32,8 @@ if ![gdb_guile_runto_main] { return } +set debug_types [debug_types] + # Setup and get the symbol table. set line_no [gdb_get_line_number "Block break here."] gdb_breakpoint $line_no @@ -101,8 +103,21 @@ gdb_test "guile (print (->bool (member \"int\" static-symbols)))" \ "#t" "test int in static symbols" gdb_test "guile (print (->bool (member \"char\" static-symbols)))" \ "#t" "test char in static symbols" -gdb_test "guile (print (->bool (member \"simple_struct\" static-symbols)))" \ - "#t" "test simple_struct in static symbols" +gdb_test_multiple \ + "guile (print (->bool (member \"simple_struct\" static-symbols)))" \ + "test simple_struct in static symbols" { + -re -wrap "#t" { + pass $gdb_test_name + } + -re -wrap "#f" { + if { $debug_types } { + # Xfail for PR gcc/90232. + xfail $gdb_test_name + } else { + fail $gdb_test_name + } + } + } # Test is_valid when the objfile is unloaded. This must be the last # test as it unloads the object file in GDB. diff --git a/gdb/testsuite/gdb.python/py-symtab.exp b/gdb/testsuite/gdb.python/py-symtab.exp index 836cfd23675..a0fe885bdfc 100644 --- a/gdb/testsuite/gdb.python/py-symtab.exp +++ b/gdb/testsuite/gdb.python/py-symtab.exp @@ -32,6 +32,8 @@ if ![runto_main] then { return 0 } +set debug_types [debug_types] + global hex decimal # Setup and get the symbol table. @@ -75,7 +77,20 @@ gdb_test "python print (\"func\" in global_symbols)" "True" "test func in global gdb_test "python print (\"main\" in global_symbols)" "True" "test main in global symbols" gdb_test "python print (\"int\" in static_symbols)" "True" "test int in static symbols" gdb_test "python print (\"char\" in static_symbols)" "True" "test char in static symbols" -gdb_test "python print (\"simple_struct\" in static_symbols)" "True" "test simple_struct in static symbols" +gdb_test_multiple "python print (\"simple_struct\" in static_symbols)" \ + "test simple_struct in static symbols" { + -re -wrap "True" { + pass $gdb_test_name + } + -re -wrap "False" { + if { $debug_types } { + # Xfail for PR gcc/90232. + xfail $gdb_test_name + } else { + fail $gdb_test_name + } + } + } # Test is_valid when the objfile is unloaded. This must be the last # test as it unloads the object file in GDB. diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 2208f3a1a9b..b72ce0cda7f 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -7106,5 +7106,23 @@ proc ensure_gdb_index { binfile } { return -1 } +# Return 1 if executable contains .debug_types section. Otherwise, return 0. + +proc debug_types { } { + global hex + + set cmd "maint info sections" + gdb_test_multiple $cmd "" { + -re -wrap "at $hex: .debug_types.*" { + return 1 + } + -re -wrap "" { + return 0 + } + } + + return 0 +} + # Always load compatibility stuff. load_lib future.exp
reply other threads:[~2020-04-29 11:22 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200429112224.67C1238930D0@sourceware.org \ --to=vries@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).