public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Remove some dead code Date: Wed, 29 Apr 2020 14:12:11 +0000 (GMT) [thread overview] Message-ID: <20200429141211.93EAF38930CB@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=fc49bc72378b4402ca60baa5ff65f1392c92c279 commit fc49bc72378b4402ca60baa5ff65f1392c92c279 Author: Tom Tromey <tom@tromey.com> Date: Wed Apr 29 08:10:28 2020 -0600 Remove some dead code print_block_frame_labels has been commented out since 2010. I don't think we need it; this patch removes it. 2020-04-29 Tom Tromey <tom@tromey.com> * stack.c (print_block_frame_labels): Remove. Diff: --- gdb/ChangeLog | 4 ++++ gdb/stack.c | 50 -------------------------------------------------- 2 files changed, 4 insertions(+), 50 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 9e1ce39c9e2..987b997bab7 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2020-04-29 Tom Tromey <tom@tromey.com> + + * stack.c (print_block_frame_labels): Remove. + 2020-04-29 Hannes Domani <ssbssa@yahoo.de> PR gdb/17320 diff --git a/gdb/stack.c b/gdb/stack.c index af35d796d70..7f541a6a010 100644 --- a/gdb/stack.c +++ b/gdb/stack.c @@ -2257,56 +2257,6 @@ iterate_over_block_locals (const struct block *b, } } - -/* Same, but print labels. */ - -#if 0 -/* Commented out, as the code using this function has also been - commented out. FIXME:brobecker/2009-01-13: Find out why the code - was commented out in the first place. The discussion introducing - this change (2007-12-04: Support lexical blocks and function bodies - that occupy non-contiguous address ranges) did not explain why - this change was made. */ -static int -print_block_frame_labels (struct gdbarch *gdbarch, struct block *b, - int *have_default, struct ui_file *stream) -{ - struct block_iterator iter; - struct symbol *sym; - int values_printed = 0; - - ALL_BLOCK_SYMBOLS (b, iter, sym) - { - if (strcmp (sym->linkage_name (), "default") == 0) - { - if (*have_default) - continue; - *have_default = 1; - } - if (SYMBOL_CLASS (sym) == LOC_LABEL) - { - struct symtab_and_line sal; - struct value_print_options opts; - - sal = find_pc_line (SYMBOL_VALUE_ADDRESS (sym), 0); - values_printed = 1; - fputs_filtered (sym->print_name (), stream); - get_user_print_options (&opts); - if (opts.addressprint) - { - fprintf_filtered (stream, " "); - fputs_filtered (paddress (gdbarch, SYMBOL_VALUE_ADDRESS (sym)), - stream); - } - fprintf_filtered (stream, " in file %s, line %d\n", - sal.symtab->filename, sal.line); - } - } - - return values_printed; -} -#endif - /* Iterate over all the local variables in block B, including all its superblocks, stopping when the top-level block is reached. */
next reply other threads:[~2020-04-29 14:12 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-29 14:12 Tom Tromey [this message] 2022-08-31 17:14 Tom Tromey
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200429141211.93EAF38930CB@sourceware.org \ --to=tromey@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).