public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb: fix shellcheck warnings SC2086 (missing double quotes) in gdbarch.sh
@ 2020-04-30 0:36 Simon Marchi
0 siblings, 0 replies; only message in thread
From: Simon Marchi @ 2020-04-30 0:36 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a6fc5ffc502238fcc5bce98868f4f353cc5d47d1
commit a6fc5ffc502238fcc5bce98868f4f353cc5d47d1
Author: Simon Marchi <simon.marchi@efficios.com>
Date: Wed Apr 29 20:35:34 2020 -0400
gdb: fix shellcheck warnings SC2086 (missing double quotes) in gdbarch.sh
Fix all instances of:
In gdbarch.sh line 31:
if test ! -r ${file}
^-----^ SC2086: Double quote to prevent globbing and word splitting.
Did you mean:
if test ! -r "${file}"
Note that some instances of these are in text that is eval'ed. I'm
pretty sure that things could go wrong during the eval too, but that's
not something shellcheck can check.
gdb/ChangeLog:
* gdbarch.sh: Use double quotes around variables.
Diff:
---
gdb/ChangeLog | 4 ++++
gdb/gdbarch.sh | 16 ++++++++--------
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index b6928233fb8..eefeac4c180 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2020-04-29 Simon Marchi <simon.marchi@efficios.com>
+
+ * gdbarch.sh: Use double quotes around variables.
+
2020-04-29 Simon Marchi <simon.marchi@efficios.com>
* gdbarch.sh: Use %s with printf, instead of variables in the
diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh
index 2780a819f91..a934a7aa6bc 100755
--- a/gdb/gdbarch.sh
+++ b/gdb/gdbarch.sh
@@ -28,10 +28,10 @@ LC_ALL=C ; export LC_ALL
compare_new ()
{
file=$1
- if test ! -r ${file}
+ if test ! -r "${file}"
then
echo "${file} missing? cp new-${file} ${file}" 1>&2
- elif diff -u ${file} new-${file}
+ elif diff -u "${file}" "new-${file}"
then
echo "${file} unchanged" 1>&2
else
@@ -70,7 +70,7 @@ ${line}"
line="`echo "${line}" | sed -e 's/;;/; ;/g' -e 's/;;/; ;/g'`"
OFS="${IFS}" ; IFS="[;]"
- eval read ${read} <<EOF
+ eval read "${read}" <<EOF
${line}
EOF
IFS="${OFS}"
@@ -86,9 +86,9 @@ EOF
# that ended up with just that space character.
for r in ${read}
do
- if eval test \"\${${r}}\" = \"\ \"
+ if eval test "\"\${${r}}\" = ' '"
then
- eval ${r}=""
+ eval "${r}="
fi
done
@@ -1227,7 +1227,7 @@ ${class} ${returntype} ${function} ($formal)
EOF
for r in ${read}
do
- eval echo \"\ \ \ \ ${r}=\${${r}}\"
+ eval echo "\" ${r}=\${${r}}\""
done
if class_is_predicate_p && fallback_default_p
then
@@ -2162,7 +2162,7 @@ do
printf "\n"
printf "void\n"
printf "set_gdbarch_%s (struct gdbarch *gdbarch,\n" "$function"
- printf " `echo ${function} | sed -e 's/./ /g'` gdbarch_%s_ftype %s)\n" "$function" "$function"
+ printf " `echo "$function" | sed -e 's/./ /g'` gdbarch_%s_ftype %s)\n" "$function" "$function"
printf "{\n"
printf " gdbarch->%s = %s;\n" "$function" "$function"
printf "}\n"
@@ -2192,7 +2192,7 @@ do
printf "\n"
printf "void\n"
printf "set_gdbarch_%s (struct gdbarch *gdbarch,\n" "$function"
- printf " `echo ${function} | sed -e 's/./ /g'` %s %s)\n" "$returntype" "$function"
+ printf " `echo "$function" | sed -e 's/./ /g'` %s %s)\n" "$returntype" "$function"
printf "{\n"
printf " gdbarch->%s = %s;\n" "$function" "$function"
printf "}\n"
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-04-30 0:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-30 0:36 [binutils-gdb] gdb: fix shellcheck warnings SC2086 (missing double quotes) in gdbarch.sh Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).