public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Change server_command to bool
@ 2020-05-09 18:06 Tom Tromey
  0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2020-05-09 18:06 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2f78cffc1671188924ab3ec46a6a962894add49a

commit 2f78cffc1671188924ab3ec46a6a962894add49a
Author: Tom Tromey <tom@tromey.com>
Date:   Sat May 9 12:04:58 2020 -0600

    Change server_command to bool
    
    I noticed that "server_command" is an int, but really it should be a
    bool.
    
    gdb/ChangeLog
    2020-05-09  Tom Tromey  <tom@tromey.com>
    
            * top.c (server_command): Now bool.
            * top.h (server_command): Now bool.

Diff:
---
 gdb/ChangeLog | 5 +++++
 gdb/top.c     | 2 +-
 gdb/top.h     | 2 +-
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 07bc9505020..1abdf9f1db2 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2020-05-09  Tom Tromey  <tom@tromey.com>
+
+	* top.c (server_command): Now bool.
+	* top.h (server_command): Now bool.
+
 2020-05-08  Tom Tromey  <tromey@adacore.com>
 
 	* dwarf2/read.c (read_lexical_block_scope): Don't process a DIE
diff --git a/gdb/top.c b/gdb/top.c
index 9fb9d5cb5c7..3589d6b6ce7 100644
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -174,7 +174,7 @@ static const char *previous_repeat_arguments;
    whatever) can issue its own commands and also send along commands
    from the user, and have the user not notice that the user interface
    is issuing commands too.  */
-int server_command;
+bool server_command;
 
 /* Timeout limit for response from target.  */
 
diff --git a/gdb/top.h b/gdb/top.h
index 0cbb244c551..e98772a51e6 100644
--- a/gdb/top.h
+++ b/gdb/top.h
@@ -281,7 +281,7 @@ extern void gdb_init (char *);
 extern int source_line_number;
 extern std::string source_file_name;
 extern bool history_expansion_p;
-extern int server_command;
+extern bool server_command;
 extern char *lim_at_start;
 
 extern void gdb_add_history (const char *);


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-05-09 18:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-09 18:06 [binutils-gdb] Change server_command to bool Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).