public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Fix the only incorrect case found by command_structure_invariants selftest.
@ 2020-05-15 20:44 Philippe Waroquiers
  0 siblings, 0 replies; only message in thread
From: Philippe Waroquiers @ 2020-05-15 20:44 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a7b9ceb8b44cd36496e266894075e2af60c3e153

commit a7b9ceb8b44cd36496e266894075e2af60c3e153
Author: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Date:   Mon May 4 23:02:18 2020 +0200

    Fix the only incorrect case found by command_structure_invariants selftest.
    
    The next commit introduces a selftest that detects when the GDB
    command structure does not define a tree when using the pointers
    'next/*prefixlist'.  This test detects one such case, fixed
    by this commit.
    
    The command 'info set' was defined as a specific prefix command,
    but re-using the command list already used for the 'show' command.
    This leads to the command tree 'next/*prefixlist' to not be a tree.
    
    This change defines 'info set ' as an alias, thereby fixing the selftest.
    
    2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
    
            * cli/cli-cmds.c (_initialize_cli_cmds): Define 'info set' as
            an alias of 'show'.

Diff:
---
 gdb/ChangeLog      | 5 +++++
 gdb/cli/cli-cmds.c | 7 +++----
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index f91827e4ce0..619745e3240 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
+
+	* cli/cli-cmds.c (_initialize_cli_cmds): Define 'info set' as
+	an alias of 'show'.
+
 2020-05-15  Joel Brobecker  <brobecker@adacore.com>
 
 	* ada-lang.h: (ada_is_gnat_encoded_fixed_point_type): Renames
diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c
index 58e9cf31956..c17521b1f69 100644
--- a/gdb/cli/cli-cmds.c
+++ b/gdb/cli/cli-cmds.c
@@ -2209,12 +2209,11 @@ Generic command for showing things about the program being debugged."),
   add_com ("complete", class_obscure, complete_command,
 	   _("List the completions for the rest of the line as a command."));
 
-  add_show_prefix_cmd ("show", class_info, _("\
+  c = add_show_prefix_cmd ("show", class_info, _("\
 Generic command for showing things about the debugger."),
-		       &showlist, "show ", 0, &cmdlist);
+			   &showlist, "show ", 0, &cmdlist);
   /* Another way to get at the same thing.  */
-  add_show_prefix_cmd ("set", class_info, _("Show all GDB settings."),
-		       &showlist, "info set ", 0, &infolist);
+  add_alias_cmd ("set", c, class_info, 0, &infolist);
 
   c = add_com ("with", class_vars, with_command, _("\
 Temporarily set SETTING to VALUE, run COMMAND, and restore SETTING.\n\


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-05-15 20:44 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-15 20:44 [binutils-gdb] Fix the only incorrect case found by command_structure_invariants selftest Philippe Waroquiers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).