public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Fix all DUPLICATE problems in testsuite/gdb.perf/
@ 2021-09-24 16:44 Pedro Alves
  0 siblings, 0 replies; only message in thread
From: Pedro Alves @ 2021-09-24 16:44 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d8767a720e889b4b90f2a8a60a43d9fd400f4478

commit d8767a720e889b4b90f2a8a60a43d9fd400f4478
Author: Pedro Alves <pedro@palves.net>
Date:   Mon Jun 21 22:20:21 2021 +0100

    Fix all DUPLICATE problems in testsuite/gdb.perf/
    
    Currently running "make check-perf" shows:
    
     ...
     # of duplicate test names       6008
     ...
    
    All those duplicate test names come from gdb.perf/skip-command.exp.
    This commit fixes them, using with_test_prefix.
    
    gdb/testsuite/
    yyyy-mm-dd  Pedro Alves  <pedro@palves.net>
    
            * gdb.perf/skip-command.exp (run_skip_bench): Wrap each for
            iteration in with_test_prefix.
    
    Change-Id: I38501cf70bc6b60306ee7228996ee7bcd858dc1b

Diff:
---
 gdb/testsuite/gdb.perf/skip-command.exp | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/gdb/testsuite/gdb.perf/skip-command.exp b/gdb/testsuite/gdb.perf/skip-command.exp
index e396262af06..d9f31a7e8f5 100644
--- a/gdb/testsuite/gdb.perf/skip-command.exp
+++ b/gdb/testsuite/gdb.perf/skip-command.exp
@@ -101,9 +101,12 @@ proc run_skip_bench { kind text } {
     gdb_test_no_output "set variable flag = 1"
 
     for { set i 0 } { $i < 5 } { incr i } {
-	set nr_skips [expr $i * $SKIP_DIRECTIVE_COUNT]
-	install_skips $kind $text $nr_skips
-	gdb_test_python_run "SkipCommand\(\"skip-$kind-$nr_skips\", ${SKIP_STEP_COUNT}\)"
+	with_test_prefix "iter $i" {
+	    set nr_skips [expr $i * $SKIP_DIRECTIVE_COUNT]
+	    install_skips $kind $text $nr_skips
+	    gdb_test_python_run \
+		"SkipCommand\(\"skip-$kind-$nr_skips\", ${SKIP_STEP_COUNT}\)"
+	}
     }
 
     gdb_test "set variable flag = 0"


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-09-24 16:44 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-24 16:44 [binutils-gdb] Fix all DUPLICATE problems in testsuite/gdb.perf/ Pedro Alves

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).