public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb: make lwp_info non-POD
@ 2021-09-28 2:34 Simon Marchi
0 siblings, 0 replies; only message in thread
From: Simon Marchi @ 2021-09-28 2:34 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b0f6c8d24726d9bf4a5571a9c881eaa49e3129a3
commit b0f6c8d24726d9bf4a5571a9c881eaa49e3129a3
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date: Sat Aug 28 10:58:43 2021 -0400
gdb: make lwp_info non-POD
Initialize all fields in the class declaration directly. This opens the
door to using intrusive_list, done in the following patch.
Change-Id: I38bb27410cd9ebf511d310bb86fe2ea1872c3b05
Diff:
---
gdb/linux-nat.c | 27 ++++++---------------------
gdb/linux-nat.h | 38 ++++++++++++++++++++++----------------
2 files changed, 28 insertions(+), 37 deletions(-)
diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
index 0492cc02439..f063db8425b 100644
--- a/gdb/linux-nat.c
+++ b/gdb/linux-nat.c
@@ -845,19 +845,10 @@ purge_lwp_list (int pid)
static struct lwp_info *
add_initial_lwp (ptid_t ptid)
{
- struct lwp_info *lp;
-
gdb_assert (ptid.lwp_p ());
- lp = XNEW (struct lwp_info);
-
- memset (lp, 0, sizeof (struct lwp_info));
-
- lp->last_resume_kind = resume_continue;
- lp->waitstatus.kind = TARGET_WAITKIND_IGNORE;
+ lwp_info *lp = new lwp_info (ptid);
- lp->ptid = ptid;
- lp->core = -1;
/* Add to sorted-by-reverse-creation-order list. */
lwp_list_add (lp);
@@ -893,16 +884,13 @@ add_lwp (ptid_t ptid)
static void
delete_lwp (ptid_t ptid)
{
- struct lwp_info *lp;
- void **slot;
- struct lwp_info dummy;
+ lwp_info dummy (ptid);
- dummy.ptid = ptid;
- slot = htab_find_slot (lwp_lwpid_htab, &dummy, NO_INSERT);
+ void **slot = htab_find_slot (lwp_lwpid_htab, &dummy, NO_INSERT);
if (slot == NULL)
return;
- lp = *(struct lwp_info **) slot;
+ lwp_info *lp = *(struct lwp_info **) slot;
gdb_assert (lp != NULL);
htab_clear_slot (lwp_lwpid_htab, slot);
@@ -920,18 +908,15 @@ delete_lwp (ptid_t ptid)
static struct lwp_info *
find_lwp_pid (ptid_t ptid)
{
- struct lwp_info *lp;
int lwp;
- struct lwp_info dummy;
if (ptid.lwp_p ())
lwp = ptid.lwp ();
else
lwp = ptid.pid ();
- dummy.ptid = ptid_t (0, lwp);
- lp = (struct lwp_info *) htab_find (lwp_lwpid_htab, &dummy);
- return lp;
+ lwp_info dummy (ptid_t (0, lwp));
+ return (struct lwp_info *) htab_find (lwp_lwpid_htab, &dummy);
}
/* See nat/linux-nat.h. */
diff --git a/gdb/linux-nat.h b/gdb/linux-nat.h
index 83bd6d4a678..050b8046da4 100644
--- a/gdb/linux-nat.h
+++ b/gdb/linux-nat.h
@@ -202,20 +202,26 @@ struct arch_lwp_info;
struct lwp_info
{
+ lwp_info (ptid_t ptid)
+ : ptid (ptid)
+ {
+ waitstatus.kind = TARGET_WAITKIND_IGNORE;
+ }
+
/* The process id of the LWP. This is a combination of the LWP id
and overall process id. */
ptid_t ptid;
/* If this flag is set, we need to set the event request flags the
next time we see this LWP stop. */
- int must_set_ptrace_flags;
+ int must_set_ptrace_flags = 0;
/* Non-zero if we sent this LWP a SIGSTOP (but the LWP didn't report
it back yet). */
- int signalled;
+ int signalled = 0;
/* Non-zero if this LWP is stopped. */
- int stopped;
+ int stopped = 0;
/* Non-zero if this LWP will be/has been resumed. Note that an LWP
can be marked both as stopped and resumed at the same time. This
@@ -223,38 +229,38 @@ struct lwp_info
pending. We shouldn't let the LWP run until that wait status has
been processed, but we should not report that wait status if GDB
didn't try to let the LWP run. */
- int resumed;
+ int resumed = 0;
/* The last resume GDB requested on this thread. */
- enum resume_kind last_resume_kind;
+ resume_kind last_resume_kind = resume_continue;
/* If non-zero, a pending wait status. */
- int status;
+ int status = 0;
/* When 'stopped' is set, this is where the lwp last stopped, with
decr_pc_after_break already accounted for. If the LWP is
running and stepping, this is the address at which the lwp was
resumed (that is, it's the previous stop PC). If the LWP is
running and not stepping, this is 0. */
- CORE_ADDR stop_pc;
+ CORE_ADDR stop_pc = 0;
/* Non-zero if we were stepping this LWP. */
- int step;
+ int step = 0;
/* The reason the LWP last stopped, if we need to track it
(breakpoint, watchpoint, etc.). */
- enum target_stop_reason stop_reason;
+ target_stop_reason stop_reason = TARGET_STOPPED_BY_NO_REASON;
/* On architectures where it is possible to know the data address of
a triggered watchpoint, STOPPED_DATA_ADDRESS_P is non-zero, and
STOPPED_DATA_ADDRESS contains such data address. Otherwise,
STOPPED_DATA_ADDRESS_P is false, and STOPPED_DATA_ADDRESS is
undefined. Only valid if STOPPED_BY_WATCHPOINT is true. */
- int stopped_data_address_p;
- CORE_ADDR stopped_data_address;
+ int stopped_data_address_p = 0;
+ CORE_ADDR stopped_data_address = 0;
/* Non-zero if we expect a duplicated SIGINT. */
- int ignore_sigint;
+ int ignore_sigint = 0;
/* If WAITSTATUS->KIND != TARGET_WAITKIND_SPURIOUS, the waitstatus
for this LWP's last event. This may correspond to STATUS above,
@@ -269,15 +275,15 @@ struct lwp_info
enum target_waitkind syscall_state;
/* The processor core this LWP was last seen on. */
- int core;
+ int core = -1;
/* Arch-specific additions. */
- struct arch_lwp_info *arch_private;
+ struct arch_lwp_info *arch_private = nullptr;
/* Previous and next pointers in doubly-linked list of known LWPs,
sorted by reverse creation order. */
- struct lwp_info *prev;
- struct lwp_info *next;
+ struct lwp_info *prev = nullptr;
+ struct lwp_info *next = nullptr;
};
/* The global list of LWPs, for ALL_LWPS. Unlike the threads list,
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-09-28 2:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-28 2:34 [binutils-gdb] gdb: make lwp_info non-POD Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).