From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vries@sourceware.org>
Received: by sourceware.org (Postfix, from userid 2205)
 id EFDB33858424; Mon, 25 Oct 2021 16:15:18 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EFDB33858424
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Fix duplicate in gdb.mi/mi-var-cp.exp
X-Act-Checkin: binutils-gdb
X-Git-Author: Tom de Vries <tdevries@suse.de>
X-Git-Refname: refs/heads/master
X-Git-Oldrev: eb5323fdf88aff59afca0a545877c4d777ff2726
X-Git-Newrev: 9de46719da07a439af59088d69cb4dd70c030612
Message-Id: <20211025161518.EFDB33858424@sourceware.org>
Date: Mon, 25 Oct 2021 16:15:18 +0000 (GMT)
X-BeenThere: gdb-cvs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-cvs mailing list <gdb-cvs.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-cvs>,
 <mailto:gdb-cvs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-cvs/>
List-Help: <mailto:gdb-cvs-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-cvs>,
 <mailto:gdb-cvs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Oct 2021 16:15:19 -0000

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9de46719da07a439af59088d69cb4dd70c030612

commit 9de46719da07a439af59088d69cb4dd70c030612
Author: Tom de Vries <tdevries@suse.de>
Date:   Mon Oct 25 18:15:15 2021 +0200

    [gdb/testsuite] Fix duplicate in gdb.mi/mi-var-cp.exp
    
    With test-case gdb.mi/mi-var-cp.exp I run into this duplicate:
    ...
    PASS: gdb.mi/mi-var-cp.exp: run to mi-var-cp.cc:104 (set breakpoint)
    PASS: gdb.mi/mi-var-cp.exp: create varobj for s
    PASS: gdb.mi/mi-var-cp.exp: create varobj for s
    DUPLICATE: gdb.mi/mi-var-cp.exp: create varobj for s
    ...
    
    This is due to a duplicate test name here:
    ...
    $ cat -n gdb/testsuite/gdb.mi/mi-var-cp.cc
      ...
       100  int reference_to_struct ()
       101  {
       102    /*: BEGIN: reference_to_struct :*/
       103    S s = {7, 8};
       104    S& r = s;
       105    /*:
       106      mi_create_varobj S s "create varobj for s"
       107      mi_create_varobj R r "create varobj for s"
    ...
    
    Fix this by using "create varobj for r" instead.
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.mi/mi-var-cp.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.mi/mi-var-cp.cc b/gdb/testsuite/gdb.mi/mi-var-cp.cc
index 43323c49e60..0d4cd7b741d 100644
--- a/gdb/testsuite/gdb.mi/mi-var-cp.cc
+++ b/gdb/testsuite/gdb.mi/mi-var-cp.cc
@@ -104,7 +104,7 @@ int reference_to_struct ()
   S& r = s;
   /*:
     mi_create_varobj S s "create varobj for s"
-    mi_create_varobj R r "create varobj for s"
+    mi_create_varobj R r "create varobj for r"
     mi_gdb_test "-var-show-attributes S" \
 	"\\^done,attr=\"noneditable\"" \
 	"check attributes of S"