public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] sim: mloop: mark a few conditionally used funcs as unused
@ 2021-11-03  5:20 Michael Frysinger
  0 siblings, 0 replies; only message in thread
From: Michael Frysinger @ 2021-11-03  5:20 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3a275541049f295719782642fb8aa912b0a4a0d3

commit 3a275541049f295719782642fb8aa912b0a4a0d3
Author: Mike Frysinger <vapier@gentoo.org>
Date:   Wed Nov 3 01:17:17 2021 -0400

    sim: mloop: mark a few conditionally used funcs as unused
    
    These are marked inline, so building w/gcc at higher optimization
    levels will automatically discard them.  But building with -O0 will
    trigger unused function warnings, so fix that.
    
    The common before/after cover functions in the common mloop generator
    are not used by all architecture ports.  Doesn't seem to be a hard
    requirement, so marking them optional (i.e. unused) is fine.
    
    The cris execute function is conditionally used depending on the
    fast-build mode settings, so mark it unused too.

Diff:
---
 sim/common/genmloop.sh | 4 ++--
 sim/cris/mloop.in      | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/sim/common/genmloop.sh b/sim/common/genmloop.sh
index 572dc8a9ed4..b8a0f435a09 100755
--- a/sim/common/genmloop.sh
+++ b/sim/common/genmloop.sh
@@ -349,7 +349,7 @@ static INLINE void
    This is as opposed to x-after which is only emitted at the end of a group
    of parallel insns.  */
 
-static INLINE void
+ATTRIBUTE_UNUSED static INLINE void
 @prefix@_emit_before (SIM_CPU *current_cpu, SCACHE *sc, PCADDR pc, int first_p)
 {
   ARGBUF *abuf = &sc[0].argbuf;
@@ -364,7 +364,7 @@ static INLINE void
    x-after is emitted after a serial insn or at the end of a group of
    parallel insns.  */
 
-static INLINE void
+ATTRIBUTE_UNUSED static INLINE void
 @prefix@_emit_after (SIM_CPU *current_cpu, SCACHE *sc, PCADDR pc)
 {
   ARGBUF *abuf = &sc[0].argbuf;
diff --git a/sim/cris/mloop.in b/sim/cris/mloop.in
index 645d8211606..da800e745af 100644
--- a/sim/cris/mloop.in
+++ b/sim/cris/mloop.in
@@ -67,7 +67,8 @@ extract (SIM_CPU *current_cpu, PCADDR pc, CGEN_INSN_INT insn, ARGBUF *abuf,
   return id;
 }
 
-static INLINE SEM_PC
+/* This might not be used directly depending on the fast compile mode.  */
+ATTRIBUTE_UNUSED static INLINE SEM_PC
 execute (SIM_CPU *current_cpu, SCACHE *sc, int fast_p)
 {
   SEM_PC vpc;


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-11-03  5:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-03  5:20 [binutils-gdb] sim: mloop: mark a few conditionally used funcs as unused Michael Frysinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).