public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Fix error in file_and_directory patch
@ 2021-12-08 20:07 Tom Tromey
0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2021-12-08 20:07 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=621f8c42d3df079ca5781cdb0925c5ec3498f59c
commit 621f8c42d3df079ca5781cdb0925c5ec3498f59c
Author: Tom Tromey <tromey@adacore.com>
Date: Wed Dec 8 12:52:34 2021 -0700
Fix error in file_and_directory patch
In my earlier C++-ization patch for file_and_directory, I introduced
an error:
- if (strcmp (fnd.name, "<unknown>") != 0)
+ if (fnd.is_unknown ())
This change inverted the sense of the test, which causes failures with
.debug_names.
This patch fixes the bug. Regression tested on x86-64 Fedora 34. I
also tested it using the AdaCore internal test suite, with
.debug_names -- this was failing before, and now it works.
Diff:
---
gdb/dwarf2/read.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index f2d7da7de52..dd2134b3c63 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -3008,7 +3008,7 @@ dw2_get_file_names_reader (const struct die_reader_specs *reader,
file_and_directory &fnd = find_file_and_directory (comp_unit_die, cu);
int offset = 0;
- if (fnd.is_unknown ())
+ if (!fnd.is_unknown ())
++offset;
else if (lh == nullptr)
return;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-12-08 20:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-08 20:07 [binutils-gdb] Fix error in file_and_directory patch Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).