public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Filtered output cleanup in expression dumping Date: Wed, 5 Jan 2022 18:54:26 +0000 (GMT) [thread overview] Message-ID: <20220105185426.B24513858410@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=729a211143c69e42debcb26bec7071d958e12b45 commit 729a211143c69e42debcb26bec7071d958e12b45 Author: Tom Tromey <tom@tromey.com> Date: Thu Dec 30 12:34:15 2021 -0700 Filtered output cleanup in expression dumping Most of the expression-dumping code uses filtered output, but a few functions did not. This patch cleans up these instance. Note that this won't cause any behavior change, because the only calls to dump_prefix_expression pass in gdb_stdlog. However, in the long run it's easier to audit the code if the number of uses of _unfiltered is reduced. Diff: --- gdb/expprint.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/gdb/expprint.c b/gdb/expprint.c index f6dbde29469..381a10d85be 100644 --- a/gdb/expprint.c +++ b/gdb/expprint.c @@ -138,9 +138,9 @@ dump_for_expression (struct ui_file *stream, int depth, { fprintf_filtered (stream, _("%*sType flags: "), depth, ""); if (flags & TYPE_INSTANCE_FLAG_CONST) - fputs_unfiltered ("const ", stream); + fputs_filtered ("const ", stream); if (flags & TYPE_INSTANCE_FLAG_VOLATILE) - fputs_unfiltered ("volatile", stream); + fputs_filtered ("volatile", stream); fprintf_filtered (stream, "\n"); } @@ -152,24 +152,24 @@ dump_for_expression (struct ui_file *stream, int depth, switch (flags & ~C_CHAR) { case C_WIDE_STRING: - fputs_unfiltered (_("wide "), stream); + fputs_filtered (_("wide "), stream); break; case C_STRING_16: - fputs_unfiltered (_("u16 "), stream); + fputs_filtered (_("u16 "), stream); break; case C_STRING_32: - fputs_unfiltered (_("u32 "), stream); + fputs_filtered (_("u32 "), stream); break; default: - fputs_unfiltered (_("ordinary "), stream); + fputs_filtered (_("ordinary "), stream); break; } if ((flags & C_CHAR) != 0) - fputs_unfiltered (_("char"), stream); + fputs_filtered (_("char"), stream); else - fputs_unfiltered (_("string"), stream); - fputs_unfiltered ("\n", stream); + fputs_filtered (_("string"), stream); + fputs_filtered ("\n", stream); } void @@ -178,13 +178,13 @@ dump_for_expression (struct ui_file *stream, int depth, { fprintf_filtered (stream, _("%*sRange:"), depth, ""); if ((flags & RANGE_LOW_BOUND_DEFAULT) != 0) - fputs_unfiltered (_("low-default "), stream); + fputs_filtered (_("low-default "), stream); if ((flags & RANGE_HIGH_BOUND_DEFAULT) != 0) - fputs_unfiltered (_("high-default "), stream); + fputs_filtered (_("high-default "), stream); if ((flags & RANGE_HIGH_BOUND_EXCLUSIVE) != 0) - fputs_unfiltered (_("high-exclusive "), stream); + fputs_filtered (_("high-exclusive "), stream); if ((flags & RANGE_HAS_STRIDE) != 0) - fputs_unfiltered (_("has-stride"), stream); + fputs_filtered (_("has-stride"), stream); fprintf_filtered (stream, "\n"); }
reply other threads:[~2022-01-05 18:54 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220105185426.B24513858410@sourceware.org \ --to=tromey@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).