public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Lancelot SIX <lsix@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] gdb/testsuite: Remove duplicates from gdb.base/dfp-test.exp
Date: Fri,  7 Jan 2022 22:45:21 +0000 (GMT)	[thread overview]
Message-ID: <20220107224521.661723857C7C@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0fb8b9ba93ba2e26d9b6091c3cb8404a5178f747

commit 0fb8b9ba93ba2e26d9b6091c3cb8404a5178f747
Author: Lancelot SIX <lsix@lancelotsix.com>
Date:   Sat Nov 20 00:10:07 2021 +0000

    gdb/testsuite: Remove duplicates from gdb.base/dfp-test.exp
    
    When running the testsuite, I have:
    
        Running .../gdb/testsuite/gdb.base/dfp-test.exp ...
        DUPLICATE: gdb.base/dfp-test.exp: 1.23E is an invalid number
        DUPLICATE: gdb.base/dfp-test.exp: 1.23E45A is an invalid number
        DUPLICATE: gdb.base/dfp-test.exp: 1.23E is an invalid number
        DUPLICATE: gdb.base/dfp-test.exp: 1.23E45A is an invalid number
    
    Fix by using proc_with_prefix where appropriate.
    
    Tested on x86_64-linux.
    Co-Authored-By: Andrew Burgess <aburgess@redhat.com>

Diff:
---
 gdb/testsuite/gdb.base/dfp-test.exp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gdb/testsuite/gdb.base/dfp-test.exp b/gdb/testsuite/gdb.base/dfp-test.exp
index e43ecd0e15e..4866d0ae094 100644
--- a/gdb/testsuite/gdb.base/dfp-test.exp
+++ b/gdb/testsuite/gdb.base/dfp-test.exp
@@ -36,7 +36,7 @@ if ![runto_main] then {
 
 set sizeof_long [get_sizeof "long" 4]
 
-proc d32_set_tests {} {
+proc_with_prefix d32_set_tests {} {
 
     gdb_test "p d32=123.45df" " = 123.45"
     gdb_test "p d32=12345.df" " = 12345"
@@ -67,7 +67,7 @@ proc d32_set_tests {} {
     gdb_test "p d32=1.23E45Adf" ".*Conversion syntax.*" "1.23E45A is an invalid number"
 }
 
-proc d64_set_tests {} {
+proc_with_prefix d64_set_tests {} {
 
     gdb_test "p d64=123.45dd" " = 123.45"
     gdb_test "p d64=12345.dd" " = 12345"
@@ -97,7 +97,7 @@ proc d64_set_tests {} {
     gdb_test "p d64=1.23E45Add" ".*Conversion syntax.*" "1.23E45A is an invalid number"
 }
 
-proc d128_set_tests {} {
+proc_with_prefix d128_set_tests {} {
 
     gdb_test "p d128=123.45dl" " = 123.45"
     gdb_test "p d128=12345.dl" " = 12345"


                 reply	other threads:[~2022-01-07 22:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220107224521.661723857C7C@sourceware.org \
    --to=lsix@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).