public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Lancelot SIX <lsix@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] gdb/testsuite: Remove duplicates from gdb.base/exprs.exp
Date: Fri,  7 Jan 2022 22:46:01 +0000 (GMT)	[thread overview]
Message-ID: <20220107224601.F2B103857C67@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1868c0cb3378ba3984c056b3850cc93eaa709e04

commit 1868c0cb3378ba3984c056b3850cc93eaa709e04
Author: Lancelot SIX <lsix@lancelotsix.com>
Date:   Sun Nov 21 00:44:36 2021 +0000

    gdb/testsuite: Remove duplicates from gdb.base/exprs.exp
    
    When running the testsuite, I have:
    
        Running .../gdb/testsuite/gdb.base/exprs.exp ...
        DUPLICATE: gdb.base/exprs.exp: \$[0-9]* = red (setup)
    
    Fix by using with_test_prefix where appropriate.
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.base/exprs.exp | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/gdb/testsuite/gdb.base/exprs.exp b/gdb/testsuite/gdb.base/exprs.exp
index 0d080e31c76..c67647a67db 100644
--- a/gdb/testsuite/gdb.base/exprs.exp
+++ b/gdb/testsuite/gdb.base/exprs.exp
@@ -237,10 +237,12 @@ test_expr "print \"x\" \"y\" \"z\"" "\\$\[0-9\]* = \"xyz\""
 
 # Enum formatting tests.
 test_expr "print red" "\\$\[0-9\]* = red"
-gdb_test "set output-radix 8" ".*"
-test_expr "print red" "\\$\[0-9\]* = red"
-test_expr "print/d red" "\\$\[0-9\]* = 0"
-gdb_test "set output-radix 10" ".*"
+with_test_prefix "output-radix 8" {
+    gdb_test "set output-radix 8" ".*"
+    test_expr "print red" "\\$\[0-9\]* = red"
+    test_expr "print/d red" "\\$\[0-9\]* = 0"
+    gdb_test "set output-radix 10" ".*"
+}
 
 # Pre-/post in-/decrement tests.
 gdb_test "set variable v_int = 1" ""


                 reply	other threads:[~2022-01-07 22:46 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220107224601.F2B103857C67@sourceware.org \
    --to=lsix@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).