public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Lancelot SIX <lsix@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] gdb/testsuite: Remove duplicates from gdb.threads/staticthreads.ex
Date: Fri,  7 Jan 2022 22:47:12 +0000 (GMT)	[thread overview]
Message-ID: <20220107224712.EBCD03857C6D@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4df98d9d31173d45438fbf000e6ed2d3cdd98ae2

commit 4df98d9d31173d45438fbf000e6ed2d3cdd98ae2
Author: Lancelot SIX <lsix@lancelotsix.com>
Date:   Tue Nov 23 16:40:24 2021 +0000

    gdb/testsuite: Remove duplicates from gdb.threads/staticthreads.ex
    
    When running the testsuite, I have:
    
        Running .../gdb/testsuite/gdb.threads/staticthreads.exp ...
        DUPLICATE: gdb.threads/staticthreads.exp: couldn't compile staticthreads.c: unrecognized error
    
    Fix by using foreach_with_prefix instead of foreach when preparing the
    test case.
    
    Testeed on x86_64-linux both in a setup where the test fails to prepare
    and in a setup where the test fails to setup.

Diff:
---
 gdb/testsuite/gdb.threads/staticthreads.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.threads/staticthreads.exp b/gdb/testsuite/gdb.threads/staticthreads.exp
index cc4867dd459..788fb53b21b 100644
--- a/gdb/testsuite/gdb.threads/staticthreads.exp
+++ b/gdb/testsuite/gdb.threads/staticthreads.exp
@@ -22,7 +22,7 @@
 standard_testfile
 set static_flag "-static"
 
-foreach have_tls { "-DHAVE_TLS" "" } {
+foreach_with_prefix have_tls { "-DHAVE_TLS" "" } {
     if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" \
 	     executable \
 	     [list debug "additional_flags=${static_flag} ${have_tls}" \


                 reply	other threads:[~2022-01-07 22:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220107224712.EBCD03857C6D@sourceware.org \
    --to=lsix@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).