public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb/testsuite: Remove duplicates from gdb.threads/staticthreads.ex
@ 2022-01-07 22:47 Lancelot SIX
  0 siblings, 0 replies; only message in thread
From: Lancelot SIX @ 2022-01-07 22:47 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4df98d9d31173d45438fbf000e6ed2d3cdd98ae2

commit 4df98d9d31173d45438fbf000e6ed2d3cdd98ae2
Author: Lancelot SIX <lsix@lancelotsix.com>
Date:   Tue Nov 23 16:40:24 2021 +0000

    gdb/testsuite: Remove duplicates from gdb.threads/staticthreads.ex
    
    When running the testsuite, I have:
    
        Running .../gdb/testsuite/gdb.threads/staticthreads.exp ...
        DUPLICATE: gdb.threads/staticthreads.exp: couldn't compile staticthreads.c: unrecognized error
    
    Fix by using foreach_with_prefix instead of foreach when preparing the
    test case.
    
    Testeed on x86_64-linux both in a setup where the test fails to prepare
    and in a setup where the test fails to setup.

Diff:
---
 gdb/testsuite/gdb.threads/staticthreads.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.threads/staticthreads.exp b/gdb/testsuite/gdb.threads/staticthreads.exp
index cc4867dd459..788fb53b21b 100644
--- a/gdb/testsuite/gdb.threads/staticthreads.exp
+++ b/gdb/testsuite/gdb.threads/staticthreads.exp
@@ -22,7 +22,7 @@
 standard_testfile
 set static_flag "-static"
 
-foreach have_tls { "-DHAVE_TLS" "" } {
+foreach_with_prefix have_tls { "-DHAVE_TLS" "" } {
     if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" \
 	     executable \
 	     [list debug "additional_flags=${static_flag} ${have_tls}" \


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-01-07 22:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-07 22:47 [binutils-gdb] gdb/testsuite: Remove duplicates from gdb.threads/staticthreads.ex Lancelot SIX

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).