From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1879) id 17FF13857018; Tue, 22 Feb 2022 14:32:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 17FF13857018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Simon Marchi To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb/testsuite/README: point to default value of INTERNAL_GDBFLAGS X-Act-Checkin: binutils-gdb X-Git-Author: Philippe Blain X-Git-Refname: refs/heads/master X-Git-Oldrev: 3a3e333f65483b864bf2624392f8aa4a88c7a498 X-Git-Newrev: 955b0ef98ea757bad1b9be429e4b8d13689da13b Message-Id: <20220222143253.17FF13857018@sourceware.org> Date: Tue, 22 Feb 2022 14:32:53 +0000 (GMT) X-BeenThere: gdb-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Feb 2022 14:32:53 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D955b0ef98ea7= 57bad1b9be429e4b8d13689da13b commit 955b0ef98ea757bad1b9be429e4b8d13689da13b Author: Philippe Blain Date: Sun Feb 20 11:49:12 2022 -0500 gdb/testsuite/README: point to default value of INTERNAL_GDBFLAGS =20 The INTERNAL_GDBFLAGS runtest variable was updated in 55c3ad88013 ([gdb/testsuite] Prevent pagination in GDB_INTERNALFLAGS, 2020-10-26) to disable pagination, and in aae1c79a03a (PR python/12227..., 2010-12-07) to point to the data directory, but its default value mentioned in the testsuite's README was not kept up to date. =20 To avoid it getting out of sync even more, point the reader to the definition of the variable in lib/gdb.exp, and move the explanation of the different flags there. Also adjust the example in the README so it follows the flags added in 55c3ad88013. =20 Change-Id: I3533608a7d6ae5198af09c7dc7743bde24c19ed7 Diff: --- gdb/testsuite/README | 12 +++++------- gdb/testsuite/lib/gdb.exp | 4 ++++ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/gdb/testsuite/README b/gdb/testsuite/README index 7552774c78b..c2f659a7188 100644 --- a/gdb/testsuite/README +++ b/gdb/testsuite/README @@ -167,12 +167,7 @@ checks both the installed GDB and GDBserver. INTERNAL_GDBFLAGS =20 Command line options passed to all GDB invocations. - -The default is "-nw -nx". - -`-nw' disables any of the windowed interfaces. -`-nx' disables ~/.gdbinit, so that it doesn't interfere with -the tests. +The default is set in lib/gdb.exp. =20 This is actually considered an internal variable, and you won't normally want to change it. However, in some situations, @@ -193,7 +188,10 @@ a .gdbinit. For example: HOME=3D`pwd` runtest \ GDB=3D/usr/bin/gdb \ GDBSERVER=3D/usr/bin/gdbserver \ - INTERNAL_GDBFLAGS=3D-nw + INTERNAL_GDBFLAGS=3D"-nw -iex 'set height 0' -iex 'set width 0'" + +Note that we do not need to specify '-data-directory' here +as we are testing an installed GDB. =20 GDB_PARALLEL =20 diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index a3717a40229..0cec46731bb 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -129,6 +129,10 @@ verbose "using GDBFLAGS =3D $GDBFLAGS" 2 set BUILD_DATA_DIRECTORY "[pwd]/../data-directory" =20 # INTERNAL_GDBFLAGS contains flags that the testsuite requires. +# `-nw' disables any of the windowed interfaces. +# `-nx' disables ~/.gdbinit, so that it doesn't interfere with the tests. +# `-data-directory' points to the data directory in the build directory. +# `-iex "set {height,width} 0"' disables pagination. global INTERNAL_GDBFLAGS if ![info exists INTERNAL_GDBFLAGS] { set INTERNAL_GDBFLAGS \