public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb-add-index: disable debuginfod
@ 2022-02-25 22:34 Aaron Merey
  0 siblings, 0 replies; only message in thread
From: Aaron Merey @ 2022-02-25 22:34 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=18694ad5bddc06bea69600d97f048f255e02494f

commit 18694ad5bddc06bea69600d97f048f255e02494f
Author: Aaron Merey <amerey@redhat.com>
Date:   Fri Feb 11 19:28:47 2022 -0500

    gdb-add-index: disable debuginfod
    
    gdb-add-index may trigger debuginfod's first-use notice.  The notice
    is misleading in this case.  It instructs the user to modify .gdbinit
    in order to permanently enable/disable debuginfod but gdb-add-index
    invokes gdb with -nx which ignores .gdbinit.
    
    Additionally debuginfod is not needed for gdb-add-index since the
    symbol file is given as an argument and should already be present
    locally.
    
    Fix this by disabling debuginfod when gdb-add-index invokes gdb.

Diff:
---
 gdb/contrib/gdb-add-index.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gdb/contrib/gdb-add-index.sh b/gdb/contrib/gdb-add-index.sh
index 0ff943d506e..591f32bbbbe 100755
--- a/gdb/contrib/gdb-add-index.sh
+++ b/gdb/contrib/gdb-add-index.sh
@@ -112,6 +112,7 @@ rm -f $tmp_files
 trap "rm -f $tmp_files" 0
 
 $GDB --batch -nx -iex 'set auto-load no' \
+    -iex 'set debuginfod enabled off' \
     -ex "file $file" -ex "save gdb-index $dwarf5 $dir" || {
     # Just in case.
     status=$?


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-02-25 22:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-25 22:34 [binutils-gdb] gdb-add-index: disable debuginfod Aaron Merey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).