public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Fix maybe-uninitialized warning in py-infthread.c
@ 2022-02-28 17:54 Tom Tromey
  0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2022-02-28 17:54 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=29928b8e3b79e14abb11cfa78daec447158b79d4

commit 29928b8e3b79e14abb11cfa78daec447158b79d4
Author: Tom Tromey <tromey@adacore.com>
Date:   Mon Feb 28 10:53:13 2022 -0700

    Fix maybe-uninitialized warning in py-infthread.c
    
    I got this warning from py-infthread.c using the Fedora 34 system GCC:
    
    ../../binutils-gdb/gdb/python/py-infthread.c:102:30: warning: ‘extra_info’ may be used uninitialized in this function [-Wmaybe-uninitialized]
    
    I think this happens because GDB_PY_HANDLE_EXCEPTION expands to an
    'if' whose condition is always true -- but GCC can't know this.  This
    patch avoids the warning by adding a harmless initialization.

Diff:
---
 gdb/python/py-infthread.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gdb/python/py-infthread.c b/gdb/python/py-infthread.c
index 66c3efdf6cc..c94d5b0ddab 100644
--- a/gdb/python/py-infthread.c
+++ b/gdb/python/py-infthread.c
@@ -87,7 +87,9 @@ thpy_get_details (PyObject *self, void *ignore)
 
   THPY_REQUIRE_VALID (thread_obj);
 
-  const char *extra_info;
+  /* GCC can't tell that extra_info will always be assigned after the
+     'catch', so initialize it.  */
+  const char *extra_info = nullptr;
   try
     {
       extra_info = target_extra_thread_info (thread_obj->thread);


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-02-28 17:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-28 17:54 [binutils-gdb] Fix maybe-uninitialized warning in py-infthread.c Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).