From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1936) id 42FE3385B804; Fri, 1 Apr 2022 20:19:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 42FE3385B804 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: John Baldwin To: gdb-cvs@sourceware.org Subject: [binutils-gdb] FreeBSD/x86: Read segment base registers from NT_X86_SEGBASES. X-Act-Checkin: binutils-gdb X-Git-Author: John Baldwin X-Git-Refname: refs/heads/master X-Git-Oldrev: b5c2367c3ac5f696221d9c24f470498abdb83257 X-Git-Newrev: f3215e1526d762f005fdf86abac81da514c74e50 Message-Id: <20220401201945.42FE3385B804@sourceware.org> Date: Fri, 1 Apr 2022 20:19:45 +0000 (GMT) X-BeenThere: gdb-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2022 20:19:45 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Df3215e1526d7= 62f005fdf86abac81da514c74e50 commit f3215e1526d762f005fdf86abac81da514c74e50 Author: John Baldwin Date: Fri Apr 1 13:16:46 2022 -0700 FreeBSD/x86: Read segment base registers from NT_X86_SEGBASES. =20 FreeBSD kernels recently grew a new register core dump note containing the base addresses of the %fs and %gs segments (corresponding to the %fsbase and %gsbase registers). Parse this note to permit inspecting TLS variables in core dumps. Native processes already supported TLS via older ptrace() operations. Diff: --- gdb/amd64-fbsd-tdep.c | 18 ++++++++++++++++++ gdb/i386-fbsd-tdep.c | 18 ++++++++++++++++++ 2 files changed, 36 insertions(+) diff --git a/gdb/amd64-fbsd-tdep.c b/gdb/amd64-fbsd-tdep.c index da5c297902d..55764beaad2 100644 --- a/gdb/amd64-fbsd-tdep.c +++ b/gdb/amd64-fbsd-tdep.c @@ -37,6 +37,9 @@ 16-bit segment registers. */ #define AMD64_FBSD_SIZEOF_GREGSET (22 * 8) =20 +/* The segment base register set consists of 2 64-bit registers. */ +#define AMD64_FBSD_SIZEOF_SEGBASES_REGSET (2 * 8) + /* Register maps. */ =20 static const struct regcache_map_entry amd64_fbsd_gregmap[] =3D @@ -70,6 +73,13 @@ static const struct regcache_map_entry amd64_fbsd_gregma= p[] =3D { 0 } }; =20 +static const struct regcache_map_entry amd64_fbsd_segbases_regmap[] =3D +{ + { 1, AMD64_FSBASE_REGNUM, 0 }, + { 1, AMD64_GSBASE_REGNUM, 0 }, + { 0 } +}; + /* This layout including fsbase and gsbase was adopted in FreeBSD 8.0. */ =20 @@ -120,6 +130,11 @@ const struct regset amd64_fbsd_gregset =3D amd64_fbsd_gregmap, regcache_supply_regset, regcache_collect_regset }; =20 +const struct regset amd64_fbsd_segbases_regset =3D +{ + amd64_fbsd_segbases_regmap, regcache_supply_regset, regcache_collect_reg= set +}; + /* Support for signal handlers. */ =20 /* In a signal frame, rsp points to a 'struct sigframe' which is @@ -253,6 +268,9 @@ amd64fbsd_iterate_over_regset_sections (struct gdbarch = *gdbarch, &amd64_fbsd_gregset, NULL, cb_data); cb (".reg2", tdep->sizeof_fpregset, tdep->sizeof_fpregset, &amd64_fpregs= et, NULL, cb_data); + cb (".reg-x86-segbases", AMD64_FBSD_SIZEOF_SEGBASES_REGSET, + AMD64_FBSD_SIZEOF_SEGBASES_REGSET, &amd64_fbsd_segbases_regset, + "segment bases", cb_data); cb (".reg-xstate", X86_XSTATE_SIZE (tdep->xcr0), X86_XSTATE_SIZE (tdep->= xcr0), &amd64fbsd_xstateregset, "XSAVE extended state", cb_data); } diff --git a/gdb/i386-fbsd-tdep.c b/gdb/i386-fbsd-tdep.c index 16ffd576323..fad091f8472 100644 --- a/gdb/i386-fbsd-tdep.c +++ b/gdb/i386-fbsd-tdep.c @@ -35,6 +35,9 @@ /* The general-purpose regset consists of 19 32-bit slots. */ #define I386_FBSD_SIZEOF_GREGSET (19 * 4) =20 +/* The segment base register set consists of 2 32-bit registers. */ +#define I386_FBSD_SIZEOF_SEGBASES_REGSET (2 * 4) + /* Register maps. */ =20 static const struct regcache_map_entry i386_fbsd_gregmap[] =3D @@ -61,6 +64,13 @@ static const struct regcache_map_entry i386_fbsd_gregmap= [] =3D { 0 } }; =20 +static const struct regcache_map_entry i386_fbsd_segbases_regmap[] =3D +{ + { 1, I386_FSBASE_REGNUM, 0 }, + { 1, I386_GSBASE_REGNUM, 0 }, + { 0 } +}; + /* This layout including fsbase and gsbase was adopted in FreeBSD 8.0. */ =20 @@ -103,6 +113,11 @@ const struct regset i386_fbsd_gregset =3D i386_fbsd_gregmap, regcache_supply_regset, regcache_collect_regset }; =20 +const struct regset i386_fbsd_segbases_regset =3D +{ + i386_fbsd_segbases_regmap, regcache_supply_regset, regcache_collect_regs= et +}; + /* Support for signal handlers. */ =20 /* In a signal frame, esp points to a 'struct sigframe' which is @@ -316,6 +331,9 @@ i386fbsd_iterate_over_regset_sections (struct gdbarch *= gdbarch, &i386_fbsd_gregset, NULL, cb_data); cb (".reg2", tdep->sizeof_fpregset, tdep->sizeof_fpregset, &i386_fpregse= t, NULL, cb_data); + cb (".reg-x86-segbases", I386_FBSD_SIZEOF_SEGBASES_REGSET, + I386_FBSD_SIZEOF_SEGBASES_REGSET, &i386_fbsd_segbases_regset, + "segment bases", cb_data); =20 if (tdep->xcr0 & X86_XSTATE_AVX) cb (".reg-xstate", X86_XSTATE_SIZE (tdep->xcr0),