From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7873) id A56883858D1E; Sat, 2 Apr 2022 00:37:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A56883858D1E Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tiezhu Yang To: bfd-cvs@sourceware.org, gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb: rename floatformats_ia64_quad to floatformats_ieee_quad X-Act-Checkin: binutils-gdb X-Git-Author: Tiezhu Yang X-Git-Refname: refs/heads/master X-Git-Oldrev: 25eb6643748279586b609a9f0e1591c032ccb123 X-Git-Newrev: 552f1157c6262e274295e9c8a131de13fa7b00a3 Message-Id: <20220402003725.A56883858D1E@sourceware.org> Date: Sat, 2 Apr 2022 00:37:25 +0000 (GMT) X-BeenThere: gdb-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Apr 2022 00:37:25 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D552f1157c626= 2e274295e9c8a131de13fa7b00a3 commit 552f1157c6262e274295e9c8a131de13fa7b00a3 Author: Tiezhu Yang Date: Mon Mar 21 14:43:41 2022 +0800 gdb: rename floatformats_ia64_quad to floatformats_ieee_quad =20 It is better to rename floatformats_ia64_quad to floatformats_ieee_quad to reflect the reality, and then we can clean up the related code. =20 As Tom Tromey said [1]: =20 These files are maintained in gcc and then imported into the binutils-gdb repository, so any changes to them will have to be proposed there first. =20 the related changes have been merged into gcc master now [2], it is time to do it for gdb. =20 [1] https://sourceware.org/pipermail/gdb-patches/2022-March/186569.html [2] https://gcc.gnu.org/git/?p=3Dgcc.git;a=3Dcommit;h=3Db2dff6b2d9d6 =20 Signed-off-by: Tiezhu Yang Diff: --- gdb/aarch64-tdep.c | 2 +- gdb/gdbtypes.c | 8 ++++---- gdb/gdbtypes.h | 2 +- gdb/hppa-tdep.c | 2 +- gdb/i386-tdep.c | 2 +- gdb/ia64-vms-tdep.c | 2 +- gdb/loongarch-tdep.c | 2 +- gdb/mips-linux-tdep.c | 12 ++---------- gdb/mips64-obsd-tdep.c | 6 +----- gdb/ppc-linux-tdep.c | 4 ++-- gdb/riscv-tdep.c | 2 +- gdb/rs6000-tdep.c | 2 +- gdb/s390-tdep.c | 2 +- gdb/sparc-tdep.c | 6 +----- include/floatformat.h | 6 +++--- libiberty/floatformat.c | 34 +++++++++++++++++----------------- 16 files changed, 39 insertions(+), 55 deletions(-) diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c index 9a14c4d59dc..fb1434c97a3 100644 --- a/gdb/aarch64-tdep.c +++ b/gdb/aarch64-tdep.c @@ -3618,7 +3618,7 @@ aarch64_gdbarch_init (struct gdbarch_info info, struc= t gdbarch_list *arches) set_gdbarch_wchar_signed (gdbarch, 0); set_gdbarch_float_format (gdbarch, floatformats_ieee_single); set_gdbarch_double_format (gdbarch, floatformats_ieee_double); - set_gdbarch_long_double_format (gdbarch, floatformats_ia64_quad); + set_gdbarch_long_double_format (gdbarch, floatformats_ieee_quad); set_gdbarch_type_align (gdbarch, aarch64_type_align); =20 /* Detect whether PC is at a point where the stack has been destroyed. = */ diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index f55c6d19de2..1769796ab33 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -85,6 +85,10 @@ const struct floatformat *floatformats_ieee_double[BFD_E= NDIAN_UNKNOWN] =3D { &floatformat_ieee_double_big, &floatformat_ieee_double_little }; +const struct floatformat *floatformats_ieee_quad[BFD_ENDIAN_UNKNOWN] =3D { + &floatformat_ieee_quad_big, + &floatformat_ieee_quad_little +}; const struct floatformat *floatformats_ieee_double_littlebyte_bigword[BFD_= ENDIAN_UNKNOWN] =3D { &floatformat_ieee_double_big, &floatformat_ieee_double_littlebyte_bigword @@ -105,10 +109,6 @@ const struct floatformat *floatformats_ia64_spill[BFD_= ENDIAN_UNKNOWN] =3D { &floatformat_ia64_spill_big, &floatformat_ia64_spill_little }; -const struct floatformat *floatformats_ia64_quad[BFD_ENDIAN_UNKNOWN] =3D { - &floatformat_ia64_quad_big, - &floatformat_ia64_quad_little -}; const struct floatformat *floatformats_vax_f[BFD_ENDIAN_UNKNOWN] =3D { &floatformat_vax_f, &floatformat_vax_f diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h index 92a2b7cf207..24e64e343fa 100644 --- a/gdb/gdbtypes.h +++ b/gdb/gdbtypes.h @@ -2440,12 +2440,12 @@ extern const struct objfile_type *objfile_type (str= uct objfile *objfile); extern const struct floatformat *floatformats_ieee_half[BFD_ENDIAN_UNKNOWN= ]; extern const struct floatformat *floatformats_ieee_single[BFD_ENDIAN_UNKNO= WN]; extern const struct floatformat *floatformats_ieee_double[BFD_ENDIAN_UNKNO= WN]; +extern const struct floatformat *floatformats_ieee_quad[BFD_ENDIAN_UNKNOWN= ]; extern const struct floatformat *floatformats_ieee_double_littlebyte_bigwo= rd[BFD_ENDIAN_UNKNOWN]; extern const struct floatformat *floatformats_i387_ext[BFD_ENDIAN_UNKNOWN]; extern const struct floatformat *floatformats_m68881_ext[BFD_ENDIAN_UNKNOW= N]; extern const struct floatformat *floatformats_arm_ext[BFD_ENDIAN_UNKNOWN]; extern const struct floatformat *floatformats_ia64_spill[BFD_ENDIAN_UNKNOW= N]; -extern const struct floatformat *floatformats_ia64_quad[BFD_ENDIAN_UNKNOWN= ]; extern const struct floatformat *floatformats_vax_f[BFD_ENDIAN_UNKNOWN]; extern const struct floatformat *floatformats_vax_d[BFD_ENDIAN_UNKNOWN]; extern const struct floatformat *floatformats_ibm_long_double[BFD_ENDIAN_U= NKNOWN]; diff --git a/gdb/hppa-tdep.c b/gdb/hppa-tdep.c index 090d7d0c7bd..576678ae9b2 100644 --- a/gdb/hppa-tdep.c +++ b/gdb/hppa-tdep.c @@ -3072,7 +3072,7 @@ hppa_gdbarch_init (struct gdbarch_info info, struct g= dbarch_list *arches) and LP64, but might show differences some day. */ set_gdbarch_long_long_bit (gdbarch, 64); set_gdbarch_long_double_bit (gdbarch, 128); - set_gdbarch_long_double_format (gdbarch, floatformats_ia64_quad); + set_gdbarch_long_double_format (gdbarch, floatformats_ieee_quad); =20 /* The following gdbarch vector elements do not depend on the address size, or in any other gdbarch element previously set. */ diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c index 394bb08718c..870cacaf0d3 100644 --- a/gdb/i386-tdep.c +++ b/gdb/i386-tdep.c @@ -8243,7 +8243,7 @@ i386_floatformat_for_type (struct gdbarch *gdbarch, || strcmp (name, "real(kind=3D16)") =3D=3D 0 || strcmp (name, "real*16") =3D=3D 0 || strcmp (name, "REAL*16") =3D=3D 0) - return floatformats_ia64_quad; + return floatformats_ieee_quad; =20 return default_floatformat_for_type (gdbarch, name, len); } diff --git a/gdb/ia64-vms-tdep.c b/gdb/ia64-vms-tdep.c index 23f32658fbb..9b12df4fe2b 100644 --- a/gdb/ia64-vms-tdep.c +++ b/gdb/ia64-vms-tdep.c @@ -132,7 +132,7 @@ static struct libunwind_descr ia64_vms_libunwind_descr; static void ia64_openvms_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) { - set_gdbarch_long_double_format (gdbarch, floatformats_ia64_quad); + set_gdbarch_long_double_format (gdbarch, floatformats_ieee_quad); =20 #ifdef HAVE_LIBUNWIND_IA64_H /* Override the default descriptor. */ diff --git a/gdb/loongarch-tdep.c b/gdb/loongarch-tdep.c index 0eda1636561..88a838210c0 100644 --- a/gdb/loongarch-tdep.c +++ b/gdb/loongarch-tdep.c @@ -271,7 +271,7 @@ loongarch_gdbarch_init (struct gdbarch_info info, struc= t gdbarch_list *arches) set_gdbarch_float_bit (gdbarch, 32); set_gdbarch_double_bit (gdbarch, 64); set_gdbarch_long_double_bit (gdbarch, 128); - set_gdbarch_long_double_format (gdbarch, floatformats_ia64_quad); + set_gdbarch_long_double_format (gdbarch, floatformats_ieee_quad); set_gdbarch_ptr_bit (gdbarch, info.bfd_arch_info->bits_per_address); set_gdbarch_char_signed (gdbarch, 0); =20 diff --git a/gdb/mips-linux-tdep.c b/gdb/mips-linux-tdep.c index 6686355a4fe..3f4c1b321b3 100644 --- a/gdb/mips-linux-tdep.c +++ b/gdb/mips-linux-tdep.c @@ -1556,11 +1556,7 @@ mips_linux_init_abi (struct gdbarch_info info, set_solib_svr4_fetch_link_map_offsets (gdbarch, linux_ilp32_fetch_link_map_offsets); set_gdbarch_long_double_bit (gdbarch, 128); - /* These floatformats should probably be renamed. MIPS uses - the same 128-bit IEEE floating point format that IA-64 uses, - except that the quiet/signalling NaN bit is reversed (GDB - does not distinguish between quiet and signalling NaNs). */ - set_gdbarch_long_double_format (gdbarch, floatformats_ia64_quad); + set_gdbarch_long_double_format (gdbarch, floatformats_ieee_quad); tramp_frame_prepend_unwinder (gdbarch, µmips_linux_n32_rt_sigframe); tramp_frame_prepend_unwinder (gdbarch, &mips_linux_n32_rt_sigframe); @@ -1572,11 +1568,7 @@ mips_linux_init_abi (struct gdbarch_info info, set_solib_svr4_fetch_link_map_offsets (gdbarch, linux_lp64_fetch_link_map_offsets); set_gdbarch_long_double_bit (gdbarch, 128); - /* These floatformats should probably be renamed. MIPS uses - the same 128-bit IEEE floating point format that IA-64 uses, - except that the quiet/signalling NaN bit is reversed (GDB - does not distinguish between quiet and signalling NaNs). */ - set_gdbarch_long_double_format (gdbarch, floatformats_ia64_quad); + set_gdbarch_long_double_format (gdbarch, floatformats_ieee_quad); tramp_frame_prepend_unwinder (gdbarch, µmips_linux_n64_rt_sigframe); tramp_frame_prepend_unwinder (gdbarch, &mips_linux_n64_rt_sigframe); diff --git a/gdb/mips64-obsd-tdep.c b/gdb/mips64-obsd-tdep.c index 0e63d164e08..8fe2834f23a 100644 --- a/gdb/mips64-obsd-tdep.c +++ b/gdb/mips64-obsd-tdep.c @@ -29,10 +29,6 @@ #include "mips-tdep.h" #include "solib-svr4.h" =20 -/* The MIPS64 Floating-Point Quad-Precision format is similar to - big-endian IA-64 Quad-Precision format. */ -#define floatformats_mips64_quad floatformats_ia64_quad - #define MIPS64OBSD_NUM_REGS 73 =20 /* Core file support. */ @@ -150,7 +146,7 @@ mips64obsd_init_abi (struct gdbarch_info info, struct g= dbarch *gdbarch) tramp_frame_prepend_unwinder (gdbarch, &mips64obsd_sigframe); =20 set_gdbarch_long_double_bit (gdbarch, 128); - set_gdbarch_long_double_format (gdbarch, floatformats_mips64_quad); + set_gdbarch_long_double_format (gdbarch, floatformats_ieee_quad); =20 obsd_init_abi(info, gdbarch); =20 diff --git a/gdb/ppc-linux-tdep.c b/gdb/ppc-linux-tdep.c index c482598f5fa..ece7e763923 100644 --- a/gdb/ppc-linux-tdep.c +++ b/gdb/ppc-linux-tdep.c @@ -1974,7 +1974,7 @@ ppc_floatformat_for_type (struct gdbarch *gdbarch, || strcmp (name, "_Float64x") =3D=3D 0 || strcmp (name, "complex _Float128") =3D=3D 0 || strcmp (name, "complex _Float64x") =3D=3D 0) - return floatformats_ia64_quad; + return floatformats_ieee_quad; =20 if (strcmp (name, "__ibm128") =3D=3D 0) return floatformats_ibm_long_double; @@ -2053,7 +2053,7 @@ ppc_linux_init_abi (struct gdbarch_info info, to distinguish between the IBM long double and IEEE quad cases. */ set_gdbarch_long_double_bit (gdbarch, 16 * TARGET_CHAR_BIT); if (tdep->long_double_abi =3D=3D POWERPC_LONG_DOUBLE_IEEE128) - set_gdbarch_long_double_format (gdbarch, floatformats_ia64_quad); + set_gdbarch_long_double_format (gdbarch, floatformats_ieee_quad); else set_gdbarch_long_double_format (gdbarch, floatformats_ibm_long_double); =20 diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c index e569f9369b8..2752937f601 100644 --- a/gdb/riscv-tdep.c +++ b/gdb/riscv-tdep.c @@ -3769,7 +3769,7 @@ riscv_gdbarch_init (struct gdbarch_info info, set_gdbarch_float_bit (gdbarch, 32); set_gdbarch_double_bit (gdbarch, 64); set_gdbarch_long_double_bit (gdbarch, 128); - set_gdbarch_long_double_format (gdbarch, floatformats_ia64_quad); + set_gdbarch_long_double_format (gdbarch, floatformats_ieee_quad); set_gdbarch_ptr_bit (gdbarch, riscv_isa_xlen (gdbarch) * 8); set_gdbarch_char_signed (gdbarch, 0); set_gdbarch_type_align (gdbarch, riscv_type_align); diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c index c246ce8559a..5bf43644a8e 100644 --- a/gdb/rs6000-tdep.c +++ b/gdb/rs6000-tdep.c @@ -2434,7 +2434,7 @@ rs6000_builtin_type_vec128 (struct gdbarch *gdbarch) =20 /* PPC specific type for IEEE 128-bit float field */ struct type *t_float128 - =3D arch_float_type (gdbarch, 128, "float128_t", floatformats_ia64_quad); + =3D arch_float_type (gdbarch, 128, "float128_t", floatformats_ieee_quad); =20 struct type *t; =20 diff --git a/gdb/s390-tdep.c b/gdb/s390-tdep.c index 91aee632c8e..e54348be04a 100644 --- a/gdb/s390-tdep.c +++ b/gdb/s390-tdep.c @@ -7038,7 +7038,7 @@ s390_gdbarch_init (struct gdbarch_info info, struct g= dbarch_list *arches) We can safely let them default to 128-bit, since the debug info will give the size of type actually used in each case. */ set_gdbarch_long_double_bit (gdbarch, 128); - set_gdbarch_long_double_format (gdbarch, floatformats_ia64_quad); + set_gdbarch_long_double_format (gdbarch, floatformats_ieee_quad); =20 set_gdbarch_type_align (gdbarch, s390_type_align); =20 diff --git a/gdb/sparc-tdep.c b/gdb/sparc-tdep.c index 78a4d44ed5d..e540263a2fe 100644 --- a/gdb/sparc-tdep.c +++ b/gdb/sparc-tdep.c @@ -61,10 +61,6 @@ struct regset; code that can handle both. The 64-bit specific code lives in sparc64-tdep.c; don't add any here. */ =20 -/* The SPARC Floating-Point Quad-Precision format is similar to - big-endian IA-64 Quad-Precision format. */ -#define floatformats_sparc_quad floatformats_ia64_quad - /* The stack pointer is offset from the stack frame by a BIAS of 2047 (0x7ff) for 64-bit code. BIAS is likely to be defined on SPARC hosts, so undefine it first. */ @@ -1837,7 +1833,7 @@ sparc32_gdbarch_init (struct gdbarch_info info, struc= t gdbarch_list *arches) tdep->cp0_registers_num =3D ARRAY_SIZE (sparc32_cp0_register_names); =20 set_gdbarch_long_double_bit (gdbarch, 128); - set_gdbarch_long_double_format (gdbarch, floatformats_sparc_quad); + set_gdbarch_long_double_format (gdbarch, floatformats_ieee_quad); =20 set_gdbarch_wchar_bit (gdbarch, 16); set_gdbarch_wchar_signed (gdbarch, 1); diff --git a/include/floatformat.h b/include/floatformat.h index c8518790347..ffb02f9e149 100644 --- a/include/floatformat.h +++ b/include/floatformat.h @@ -97,7 +97,7 @@ struct floatformat const struct floatformat *split_half; }; =20 -/* floatformats for IEEE single and double, big and little endian. */ +/* floatformats for IEEE half, single, double and quad, big and little end= ian. */ =20 extern const struct floatformat floatformat_ieee_half_big; extern const struct floatformat floatformat_ieee_half_little; @@ -105,6 +105,8 @@ extern const struct floatformat floatformat_ieee_single= _big; extern const struct floatformat floatformat_ieee_single_little; extern const struct floatformat floatformat_ieee_double_big; extern const struct floatformat floatformat_ieee_double_little; +extern const struct floatformat floatformat_ieee_quad_big; +extern const struct floatformat floatformat_ieee_quad_little; =20 /* floatformat for ARM IEEE double, little endian bytes and big endian wor= ds */ =20 @@ -128,8 +130,6 @@ extern const struct floatformat floatformat_arm_ext_lit= tlebyte_bigword; /* IA-64 Floating Point register spilt into memory. */ extern const struct floatformat floatformat_ia64_spill_big; extern const struct floatformat floatformat_ia64_spill_little; -extern const struct floatformat floatformat_ia64_quad_big; -extern const struct floatformat floatformat_ia64_quad_little; /* IBM long double (double+double). */ extern const struct floatformat floatformat_ibm_long_double_big; extern const struct floatformat floatformat_ibm_long_double_little; diff --git a/libiberty/floatformat.c b/libiberty/floatformat.c index ce36bae7b63..f93568b375e 100644 --- a/libiberty/floatformat.c +++ b/libiberty/floatformat.c @@ -78,7 +78,7 @@ floatformat_always_valid (const struct floatformat *fmt A= TTRIBUTE_UNUSED, a system header, what we do if not, etc. */ #define FLOATFORMAT_CHAR_BIT 8 =20 -/* floatformats for IEEE half, single and double, big and little endian. = */ +/* floatformats for IEEE half, single, double and quad, big and little end= ian. */ const struct floatformat floatformat_ieee_half_big =3D { floatformat_big, 16, 0, 1, 5, 15, 31, 6, 10, @@ -127,6 +127,22 @@ const struct floatformat floatformat_ieee_double_littl= e =3D floatformat_always_valid, NULL }; +const struct floatformat floatformat_ieee_quad_big =3D +{ + floatformat_big, 128, 0, 1, 15, 16383, 0x7fff, 16, 112, + floatformat_intbit_no, + "floatformat_ieee_quad_big", + floatformat_always_valid, + NULL +}; +const struct floatformat floatformat_ieee_quad_little =3D +{ + floatformat_little, 128, 0, 1, 15, 16383, 0x7fff, 16, 112, + floatformat_intbit_no, + "floatformat_ieee_quad_little", + floatformat_always_valid, + NULL +}; =20 /* floatformat for IEEE double, little endian byte order, with big endian = word ordering, as on the ARM. */ @@ -269,22 +285,6 @@ const struct floatformat floatformat_ia64_spill_little= =3D floatformat_always_valid, NULL }; -const struct floatformat floatformat_ia64_quad_big =3D -{ - floatformat_big, 128, 0, 1, 15, 16383, 0x7fff, 16, 112, - floatformat_intbit_no, - "floatformat_ia64_quad_big", - floatformat_always_valid, - NULL -}; -const struct floatformat floatformat_ia64_quad_little =3D -{ - floatformat_little, 128, 0, 1, 15, 16383, 0x7fff, 16, 112, - floatformat_intbit_no, - "floatformat_ia64_quad_little", - floatformat_always_valid, - NULL -}; =20 static int floatformat_ibm_long_double_is_valid (const struct floatformat *fmt,