public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Simon Marchi <simark@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] gdb: make timestamped_file implement can_emit_style_escape
Date: Mon,  4 Apr 2022 21:58:53 +0000 (GMT)	[thread overview]
Message-ID: <20220404215853.9D21E3857C42@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=962937b15dd570e44109f3c8196a392b788837ba

commit 962937b15dd570e44109f3c8196a392b788837ba
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date:   Thu Mar 31 13:32:20 2022 -0400

    gdb: make timestamped_file implement can_emit_style_escape
    
    In our AMDGPU downstream port, we use styling in some logging output.
    We noticed it stopped working after the gdb_printf changes.  Making
    timestamped_file implement can_emit_style_escape (returning the value of
    the stream it wraps) fixes it.  To show that it works, modify some
    logging statements in auto-load.c to output style filenames.  You can
    see it in action by setting "set debug auto-load 1" and running a
    program.  We can incrementally add styling to other debug statements
    throughout GDB, as needed.
    
    Change-Id: I78a2fd1e078f80f2263251cf6bc53b3a9de9c17a

Diff:
---
 gdb/auto-load.c | 9 +++++----
 gdb/ui-file.h   | 3 +++
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/gdb/auto-load.c b/gdb/auto-load.c
index 057104d97b0..b6056f5d60a 100644
--- a/gdb/auto-load.c
+++ b/gdb/auto-load.c
@@ -733,8 +733,8 @@ auto_load_objfile_script_1 (struct objfile *objfile, const char *realname,
   gdb_file_up input = gdb_fopen_cloexec (filename.c_str (), "r");
   debugfile = filename.c_str ();
 
-  auto_load_debug_printf ("Attempted file \"%s\" %s.",
-			  debugfile,
+  auto_load_debug_printf ("Attempted file \"%ps\" %s.",
+			  styled_string (file_name_style.style (), debugfile),
 			  input != nullptr ? "exists" : "does not exist");
 
   std::string debugfile_holder;
@@ -763,8 +763,9 @@ auto_load_objfile_script_1 (struct objfile *objfile, const char *realname,
 
 	  input = gdb_fopen_cloexec (debugfile, "r");
 
-	  auto_load_debug_printf ("Attempted file \"%s\" %s.",
-				  debugfile,
+	  auto_load_debug_printf ("Attempted file \"%ps\" %s.",
+				  styled_string (file_name_style.style (),
+						 debugfile),
 				  (input != nullptr
 				   ? "exists"
 				   : "does not exist"));
diff --git a/gdb/ui-file.h b/gdb/ui-file.h
index f8e1fe8be3c..e420555b8a6 100644
--- a/gdb/ui-file.h
+++ b/gdb/ui-file.h
@@ -402,6 +402,9 @@ public:
   {
   }
 
+  bool can_emit_style_escape () override
+  { return m_stream->can_emit_style_escape (); }
+
   DISABLE_COPY_AND_ASSIGN (timestamped_file);
 
   void write (const char *buf, long len) override;


                 reply	other threads:[~2022-04-04 21:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220404215853.9D21E3857C42@sourceware.org \
    --to=simark@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).