public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Simon Marchi <simark@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] gdb: make timestamped_file implement write_async_safe
Date: Tue,  5 Apr 2022 00:57:48 +0000 (GMT)	[thread overview]
Message-ID: <20220405005748.DA6F23858D37@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ad62fd45460f1c6d9129115f95c9d86bcdbd8ba7

commit ad62fd45460f1c6d9129115f95c9d86bcdbd8ba7
Author: Simon Marchi <simon.marchi@efficios.com>
Date:   Mon Apr 4 20:53:52 2022 -0400

    gdb: make timestamped_file implement write_async_safe
    
    Trying to use "set debug linux-nat 1", I get an internal error:
    
        /home/smarchi/src/binutils-gdb/gdb/ui-file.h:70: internal-error: write_async_safe: write_async_safe
    
    The problem is that timestamped_file doesn't implement write_async_safe,
    which linux-nat's sigchld_handler uses.  Implement it.
    
    Change-Id: I830981010c6119f13ae673605ed015cced0f5ee8

Diff:
---
 gdb/ui-file.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gdb/ui-file.h b/gdb/ui-file.h
index e420555b8a6..bffdeaa28c4 100644
--- a/gdb/ui-file.h
+++ b/gdb/ui-file.h
@@ -405,6 +405,9 @@ public:
   bool can_emit_style_escape () override
   { return m_stream->can_emit_style_escape (); }
 
+  void write_async_safe (const char *buf, long length_buf) override
+  { return m_stream->write_async_safe (buf, length_buf); }
+
   DISABLE_COPY_AND_ASSIGN (timestamped_file);
 
   void write (const char *buf, long len) override;


                 reply	other threads:[~2022-04-05  0:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220405005748.DA6F23858D37@sourceware.org \
    --to=simark@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).