public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] gdb: make interp_add static
Date: Wed,  6 Apr 2022 14:29:32 +0000 (GMT)	[thread overview]
Message-ID: <20220406142932.5B31738515FF@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9716aa0a271cf59fb40194440ea6e2a0cf8ab192

commit 9716aa0a271cf59fb40194440ea6e2a0cf8ab192
Author: Andrew Burgess <aburgess@redhat.com>
Date:   Wed Nov 24 17:18:34 2021 +0000

    gdb: make interp_add static
    
    Since this commit:
    
      commit 8322445e0584be846f5873b9aab257dc9fbda05d
      Date:   Tue Jun 21 01:11:45 2016 +0100
    
          Introduce interpreter factories
    
    Interpreters should be registered with GDB, not by calling interp_add,
    but with a call to interp_factory_register.  I've checked the insight
    source, and it too has moved over to using interp_factory_register.
    
    In this commit I make interp_add static within interps.c.
    
    There should be no user visible change after this commit.

Diff:
---
 gdb/interps.c | 2 +-
 gdb/interps.h | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/gdb/interps.c b/gdb/interps.c
index b8df3d781e7..44002ff2cb5 100644
--- a/gdb/interps.c
+++ b/gdb/interps.c
@@ -127,7 +127,7 @@ interp_factory_register (const char *name, interp_factory_func func)
 
 /* Add interpreter INTERP to the gdb interpreter list.  The
    interpreter must not have previously been added.  */
-void
+static void
 interp_add (struct ui *ui, struct interp *interp)
 {
   struct ui_interp_info *ui_interp = get_interp_info (ui);
diff --git a/gdb/interps.h b/gdb/interps.h
index 40f6d3bc89b..330c1ba6615 100644
--- a/gdb/interps.h
+++ b/gdb/interps.h
@@ -94,8 +94,6 @@ public:
   bool inited;
 };
 
-extern void interp_add (struct ui *ui, struct interp *interp);
-
 /* Look up the interpreter for NAME, creating one if none exists yet.
    If NAME is not a interpreter type previously registered with
    interp_factory_register, return NULL; otherwise return a pointer to


                 reply	other threads:[~2022-04-06 14:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220406142932.5B31738515FF@sourceware.org \
    --to=aburgess@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).