From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id 901D8385840C; Tue, 12 Apr 2022 15:39:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 901D8385840C Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Refactor dwarf2_get_pc_bounds X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: cffae852e33b3c735cc48a398a15e7236bc39928 X-Git-Newrev: 6ee823fc4eae5024d85759bc1cc845058f1265a4 Message-Id: <20220412153930.901D8385840C@sourceware.org> Date: Tue, 12 Apr 2022 15:39:30 +0000 (GMT) X-BeenThere: gdb-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Apr 2022 15:39:30 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D6ee823fc4eae= 5024d85759bc1cc845058f1265a4 commit 6ee823fc4eae5024d85759bc1cc845058f1265a4 Author: Tom Tromey Date: Sat Jun 12 09:01:50 2021 -0600 Refactor dwarf2_get_pc_bounds =20 This changes dwarf2_get_pc_bounds so that it does not directly access a psymtab or psymtabs_addrmap. Instead, both the addrmap and the desired payload are passed as parameters. This makes it suitable to be used by the new indexer. Diff: --- gdb/dwarf2/read.c | 49 +++++++++++++++++++++++++++++-------------------- 1 file changed, 29 insertions(+), 20 deletions(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index e0ae7330732..2ec4a49b592 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -1297,7 +1297,8 @@ enum pc_bounds_kind static enum pc_bounds_kind dwarf2_get_pc_bounds (struct die_info *, CORE_ADDR *, CORE_ADDR *, struct dwarf2_cu *, - dwarf2_psymtab *); + addrmap *, + void *); =20 static void get_scope_pc_bounds (struct die_info *, CORE_ADDR *, CORE_ADDR *, @@ -7026,8 +7027,11 @@ process_psymtab_comp_unit_reader (const struct die_r= eader_specs *reader, =20 /* Possibly set the default values of LOWPC and HIGHPC from `DW_AT_ranges'. */ - cu_bounds_kind =3D dwarf2_get_pc_bounds (comp_unit_die, &best_lowpc, - &best_highpc, cu, pst); + cu_bounds_kind + =3D dwarf2_get_pc_bounds (comp_unit_die, &best_lowpc, + &best_highpc, cu, + per_bfd->partial_symtabs->psymtabs_addrmap, + pst); if (cu_bounds_kind =3D=3D PC_BOUNDS_HIGH_LOW && best_lowpc < best_highpc) { CORE_ADDR low @@ -8147,9 +8151,9 @@ add_partial_module (struct partial_die_info *pdi, COR= E_ADDR *lowpc, scan_partial_symbols (pdi->die_child, lowpc, highpc, set_addrmap, cu); } =20 -static int -dwarf2_ranges_read (unsigned, CORE_ADDR *, CORE_ADDR *, struct dwarf2_cu *, - dwarf2_psymtab *, dwarf_tag); +static int dwarf2_ranges_read (unsigned offset, CORE_ADDR *low_return, + CORE_ADDR *high_return, struct dwarf2_cu *cu, + addrmap *map, void *datum, dwarf_tag tag); =20 /* Read a partial die corresponding to a subprogram or an inlined subprogram and create a partial symbol for that subprogram. @@ -8203,6 +8207,9 @@ add_partial_subprogram (struct partial_die_info *pdi, if (pdi->has_range_info && dwarf2_ranges_read (pdi->ranges_offset, &pdi->lowpc, &pdi->highpc, cu, + (set_addrmap + ? cu->per_objfile->per_bfd->partial_symtabs->psymtabs_addrmap + : nullptr), set_addrmap ? cu->per_cu->v.psymtab : nullptr, pdi->tag)) { @@ -13098,7 +13105,7 @@ read_func_scope (struct die_info *die, struct dwarf= 2_cu *cu) } =20 /* Ignore functions with missing or invalid low and high pc attributes. = */ - if (dwarf2_get_pc_bounds (die, &lowpc, &highpc, cu, NULL) + if (dwarf2_get_pc_bounds (die, &lowpc, &highpc, cu, nullptr, nullptr) <=3D PC_BOUNDS_INVALID) { attr =3D dwarf2_attr (die, DW_AT_external, cu); @@ -13271,7 +13278,7 @@ read_lexical_block_scope (struct die_info *die, str= uct dwarf2_cu *cu) as multiple lexical blocks? Handling children in a sane way would be nasty. Might be easier to properly extend generic blocks to describe ranges. */ - switch (dwarf2_get_pc_bounds (die, &lowpc, &highpc, cu, NULL)) + switch (dwarf2_get_pc_bounds (die, &lowpc, &highpc, cu, nullptr, nullptr= )) { case PC_BOUNDS_NOT_PRESENT: /* DW_TAG_lexical_block has no attributes, process its children as if @@ -13537,7 +13544,8 @@ read_call_site_scope (struct die_info *die, struct = dwarf2_cu *cu) CORE_ADDR lowpc; =20 /* DW_AT_entry_pc should be preferred. */ - if (dwarf2_get_pc_bounds (target_die, &lowpc, NULL, target_cu, NULL) + if (dwarf2_get_pc_bounds (target_die, &lowpc, NULL, target_cu, + nullptr, nullptr) <=3D PC_BOUNDS_INVALID) complaint (_("DW_AT_call_target target DIE has invalid " "low pc, for referencing DIE %s [in module %s]"), @@ -14038,15 +14046,15 @@ dwarf2_ranges_process (unsigned offset, struct dw= arf2_cu *cu, dwarf_tag tag, =20 /* Get low and high pc attributes from DW_AT_ranges attribute value OFFSET. Return 1 if the attributes are present and valid, otherwise, return 0. - If RANGES_PST is not NULL we should set up the `psymtabs_addrmap'. */ + TAG is passed to dwarf2_ranges_process. If MAP is not NULL, then + ranges in MAP are set, using DATUM as the value. */ =20 static int dwarf2_ranges_read (unsigned offset, CORE_ADDR *low_return, CORE_ADDR *high_return, struct dwarf2_cu *cu, - dwarf2_psymtab *ranges_pst, dwarf_tag tag) + addrmap *map, void *datum, dwarf_tag tag) { struct objfile *objfile =3D cu->per_objfile->objfile; - dwarf2_per_bfd *per_bfd =3D cu->per_objfile->per_bfd; struct gdbarch *gdbarch =3D objfile->arch (); const CORE_ADDR baseaddr =3D objfile->text_section_offset (); int low_set =3D 0; @@ -14057,7 +14065,7 @@ dwarf2_ranges_read (unsigned offset, CORE_ADDR *low= _return, retval =3D dwarf2_ranges_process (offset, cu, tag, [&] (CORE_ADDR range_beginning, CORE_ADDR range_end) { - if (ranges_pst !=3D NULL) + if (map !=3D nullptr) { CORE_ADDR lowpc; CORE_ADDR highpc; @@ -14068,8 +14076,7 @@ dwarf2_ranges_read (unsigned offset, CORE_ADDR *low= _return, highpc =3D (gdbarch_adjust_dwarf2_addr (gdbarch, range_end + baseaddr) - baseaddr); - addrmap_set_empty (per_bfd->partial_symtabs->psymtabs_addrmap, - lowpc, highpc - 1, ranges_pst); + addrmap_set_empty (map, lowpc, highpc - 1, datum); } =20 /* FIXME: This is recording everything as a low-high @@ -14126,7 +14133,7 @@ dwarf2_ranges_read_low_addrs (unsigned offset, stru= ct dwarf2_cu *cu, static enum pc_bounds_kind dwarf2_get_pc_bounds (struct die_info *die, CORE_ADDR *lowpc, CORE_ADDR *highpc, struct dwarf2_cu *cu, - dwarf2_psymtab *pst) + addrmap *map, void *datum) { dwarf2_per_objfile *per_objfile =3D cu->per_objfile; struct attribute *attr; @@ -14169,8 +14176,8 @@ dwarf2_get_pc_bounds (struct die_info *die, CORE_AD= DR *lowpc, =20 /* Value of the DW_AT_ranges attribute is the offset in the .debug_ranges section. */ - if (!dwarf2_ranges_read (ranges_offset, &low, &high, cu, pst, - die->tag)) + if (!dwarf2_ranges_read (ranges_offset, &low, &high, cu, + map, datum, die->tag)) return PC_BOUNDS_INVALID; /* Found discontinuous range of addresses. */ ret =3D PC_BOUNDS_RANGES; @@ -14213,7 +14220,8 @@ dwarf2_get_subprogram_pc_bounds (struct die_info *d= ie, CORE_ADDR low, high; struct die_info *child =3D die->child; =20 - if (dwarf2_get_pc_bounds (die, &low, &high, cu, NULL) >=3D PC_BOUNDS_RAN= GES) + if (dwarf2_get_pc_bounds (die, &low, &high, cu, nullptr, nullptr) + >=3D PC_BOUNDS_RANGES) { *lowpc =3D std::min (*lowpc, low); *highpc =3D std::max (*highpc, high); @@ -14250,7 +14258,8 @@ get_scope_pc_bounds (struct die_info *die, CORE_ADDR best_high =3D (CORE_ADDR) 0; CORE_ADDR current_low, current_high; =20 - if (dwarf2_get_pc_bounds (die, ¤t_low, ¤t_high, cu, NULL) + if (dwarf2_get_pc_bounds (die, ¤t_low, ¤t_high, cu, + nullptr, nullptr) >=3D PC_BOUNDS_RANGES) { best_low =3D current_low;