From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1879) id 68B383858C53; Wed, 13 Apr 2022 18:40:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 68B383858C53 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Simon Marchi To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb: add ATTRIBUTE_PRINTF to complaint_interceptor::issue_complaint X-Act-Checkin: binutils-gdb X-Git-Author: Simon Marchi X-Git-Refname: refs/heads/master X-Git-Oldrev: febb368c894f53bd9bf0b198e0143eac02391053 X-Git-Newrev: 08755c5aadfff98c4c3db60f3043589015414f11 Message-Id: <20220413184017.68B383858C53@sourceware.org> Date: Wed, 13 Apr 2022 18:40:17 +0000 (GMT) X-BeenThere: gdb-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2022 18:40:17 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D08755c5aadff= f98c4c3db60f3043589015414f11 commit 08755c5aadfff98c4c3db60f3043589015414f11 Author: Simon Marchi Date: Wed Apr 13 11:15:38 2022 -0400 gdb: add ATTRIBUTE_PRINTF to complaint_interceptor::issue_complaint =20 Fix this error when building with clang++-14: =20 CXX complaints.o /home/smarchi/src/binutils-gdb/gdb/complaints.c:130:65: error: form= at string is not a string literal [-Werror,-Wformat-nonliteral] g_complaint_interceptor->m_complaints.insert (string_vprintf (fmt= , args)); ^~~ =20 Change-Id: I0ef11f970510eb8638d1651fa0d5eeecd6a9d31a Diff: --- gdb/complaints.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gdb/complaints.h b/gdb/complaints.h index 09d8cd39b27..68c79bd6d0a 100644 --- a/gdb/complaints.h +++ b/gdb/complaints.h @@ -70,11 +70,12 @@ private: =20 /* The saved value of deprecated_warning_hook. */ void (*m_saved_warning_hook) (const char *, va_list) - ATTRIBUTE_FPTR_PRINTF(1,0); + ATTRIBUTE_FPTR_PRINTF (1,0); =20 /* A helper function that is used by the 'complaint' implementation to issue a complaint. */ - static void issue_complaint (const char *, va_list); + static void issue_complaint (const char *, va_list) + ATTRIBUTE_PRINTF (1, 0); =20 /* This object. Used by the static callback function. */ static complaint_interceptor *g_complaint_interceptor;