From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id 1ED613857C48; Thu, 14 Apr 2022 18:21:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1ED613857C48 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Don't call QUIT in read_string X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: a69599e68bf243a50b6aee3a63ed48ada1f9c8cc X-Git-Newrev: 94ea6ddb944d985890632708865ffef4436f98c3 Message-Id: <20220414182121.1ED613857C48@sourceware.org> Date: Thu, 14 Apr 2022 18:21:21 +0000 (GMT) X-BeenThere: gdb-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Apr 2022 18:21:21 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D94ea6ddb944d= 985890632708865ffef4436f98c3 commit 94ea6ddb944d985890632708865ffef4436f98c3 Author: Tom Tromey Date: Tue Apr 12 14:40:16 2022 -0600 Don't call QUIT in read_string =20 read_string does not need to call QUIT, because target_read_memory already does. This change is needed to make string-reading usable by gdbserver. Diff: --- gdb/valprint.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/gdb/valprint.c b/gdb/valprint.c index 9990d432e35..65b85cfb038 100644 --- a/gdb/valprint.c +++ b/gdb/valprint.c @@ -2096,7 +2096,6 @@ read_string (CORE_ADDR addr, int len, int width, unsi= gned int fetchlimit, =20 do { - QUIT; nfetch =3D std::min ((unsigned long) chunksize, fetchlimit - bufsize); =20 if (*buffer =3D=3D NULL) @@ -2152,8 +2151,6 @@ read_string (CORE_ADDR addr, int len, int width, unsi= gned int fetchlimit, consider part of the string (including a '\0' which ends the string).= */ *bytes_read =3D bufptr - buffer->get (); =20 - QUIT; - return errcode; }