From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id 013193858C27; Wed, 20 Apr 2022 16:28:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 013193858C27 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Add accessors for symbol's artificial field X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: a827b8ec32f9e0ed10b2bf647ce983db813a3d3c X-Git-Newrev: 496feb16f855347dbd30fa171a8dc1d97654ae8e Message-Id: <20220420162801.013193858C27@sourceware.org> Date: Wed, 20 Apr 2022 16:28:01 +0000 (GMT) X-BeenThere: gdb-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2022 16:28:01 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D496feb16f855= 347dbd30fa171a8dc1d97654ae8e commit 496feb16f855347dbd30fa171a8dc1d97654ae8e Author: Tom Tromey Date: Sat Apr 16 12:33:56 2022 -0600 Add accessors for symbol's artificial field =20 For a series I'm experimenting with, it was handy to hide a symbol's "artificial" field behind accessors. This patch is the result. Diff: --- gdb/ada-lang.c | 6 +++--- gdb/dwarf2/read.c | 2 +- gdb/symtab.h | 16 ++++++++++++++-- 3 files changed, 18 insertions(+), 6 deletions(-) diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index 7623d0eb48d..96494538a60 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -3854,7 +3854,7 @@ ada_resolve_variable (struct symbol *sym, const struc= t block *block, candidates.end (), [] (block_symbol &bsym) { - return bsym.symbol->artificial; + return bsym.symbol->is_artificial (); }), candidates.end ()); =20 @@ -13456,9 +13456,9 @@ public: } =20 /* See language.h. */ - virtual bool symbol_printing_suppressed (struct symbol *symbol) const ov= erride + bool symbol_printing_suppressed (struct symbol *symbol) const override { - return symbol->artificial; + return symbol->is_artificial (); } =20 /* See language.h. */ diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index bb5b636e916..b7b372fcd73 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -20634,7 +20634,7 @@ new_symbol (struct die_info *die, struct type *type= , struct dwarf2_cu *cu, /* Handle DW_AT_artificial. */ attr =3D dwarf2_attr (die, DW_AT_artificial, cu); if (attr !=3D nullptr) - sym->artificial =3D attr->as_boolean (); + sym->set_is_artificial (attr->as_boolean ()); =20 /* Default assumptions. Use the passed type or decode it from the die. */ diff --git a/gdb/symtab.h b/gdb/symtab.h index 4a33c7a119f..41c8654a5ef 100644 --- a/gdb/symtab.h +++ b/gdb/symtab.h @@ -1203,7 +1203,7 @@ struct symbol : public general_symbol_info, public al= locate_on_obstack m_is_inlined (0), maybe_copied (0), subclass (SYMBOL_NONE), - artificial (false) + m_artificial (false) { /* We can't use an initializer list for members of a base class, and general_symbol_info needs to stay a POD type. */ @@ -1369,6 +1369,18 @@ struct symbol : public general_symbol_info, public a= llocate_on_obstack m_value.chain =3D sym; } =20 + /* Return true if this symbol was marked as artificial. */ + bool is_artificial () const + { + return m_artificial; + } + + /* Set the 'artificial' flag on this symbol. */ + void set_is_artificial (bool artificial) + { + m_artificial =3D artificial; + } + /* Data type of value */ =20 struct type *m_type =3D nullptr; @@ -1423,7 +1435,7 @@ struct symbol : public general_symbol_info, public al= locate_on_obstack =20 /* Whether this symbol is artificial. */ =20 - bool artificial : 1; + bool m_artificial : 1; =20 /* Line number of this symbol's definition, except for inlined functions. For an inlined function (class LOC_BLOCK and