From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1551) id B65F23899424; Thu, 21 Apr 2022 12:48:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B65F23899424 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Pedro Alves To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb.debuginfod/fetch_src_and_symbols.exp: Fix "notice empty URL" test X-Act-Checkin: binutils-gdb X-Git-Author: Pedro Alves X-Git-Refname: refs/heads/master X-Git-Oldrev: 333cd559bae5a6be60832c020da479ae23fd2664 X-Git-Newrev: 9cf71b1354f6829a999b39a675a18c5a85f19e17 Message-Id: <20220421124801.B65F23899424@sourceware.org> Date: Thu, 21 Apr 2022 12:48:01 +0000 (GMT) X-BeenThere: gdb-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Apr 2022 12:48:01 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D9cf71b1354f6= 829a999b39a675a18c5a85f19e17 commit 9cf71b1354f6829a999b39a675a18c5a85f19e17 Author: Pedro Alves Date: Thu Apr 21 13:35:09 2022 +0100 gdb.debuginfod/fetch_src_and_symbols.exp: Fix "notice empty URL" test =20 The gdb_test_multiple pattern for the "notice empty URL" test in gdb.debuginfod/fetch_src_and_symbols.exp misses expecting the prompt. Fix it by using -re -wrap. =20 Also, by using "confirm off", the message GDB prints if Debuginfod downloading is available doesn't contain "Enable debuginfod" any longer. E.g.: =20 ~~~ (gdb) file testsuite/outputs/gdb.debuginfod/fetch_src_and_symbols/fet= ch_src_and_symbols Reading symbols from testsuite/outputs/gdb.debuginfod/fetch_src_and_s= ymbols/fetch_src_and_symbols... =20 This GDB supports auto-downloading debuginfo from the following URLs: Enable debuginfod for this session? (y or [n]) ~~~ =20 ~~~ (gdb) with confirm off -- file testsuite/outputs/gdb.debuginfod/fetch= _src_and_symbols/fetch_src_and_symbols Reading symbols from testsuite/outputs/gdb.debuginfod/fetch_src_and_s= ymbols/fetch_src_and_symbols... =20 This GDB supports auto-downloading debuginfo from the following URLs: <127.0.0.1:8000> Debuginfod has been disabled. To make this setting permanent, add 'set debuginfod enabled off' to .= gdbinit. (No debugging symbols found in testsuite/outputs/gdb.debuginfod/fetch= _src_and_symbols/fetch_src_and_symbols) (gdb) ~~~ =20 I handled that correctly in the other tests that use test_urls, but had forgotten to update the "notice empty URL" one. =20 Change-Id: I00040c83466e1494b3875574eb009c571a1504bf Diff: --- gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp b/gdb/t= estsuite/gdb.debuginfod/fetch_src_and_symbols.exp index 6da9a86faa8..bd90bcd0cfe 100644 --- a/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp +++ b/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp @@ -310,7 +310,7 @@ proc local_url { } { # Disable confirmation to avoid having to deal with a query. See # test_urls. gdb_test_multiple "with confirm off -- file $binfile" "notice empty UR= L" { - -re ".*Enable debuginfod.*" { + -re -wrap "This GDB supports auto-downloading.*" { fail $gdb_test_name } -re -wrap "" {