public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Fix libinproctrace.so build on PPC
Date: Thu, 28 Apr 2022 18:52:02 +0000 (GMT)	[thread overview]
Message-ID: <20220428185202.0EECD3858405@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=fc0b8a976d17bf74cfe7310cafb602d07f2c69b9

commit fc0b8a976d17bf74cfe7310cafb602d07f2c69b9
Author: Tom Tromey <tromey@adacore.com>
Date:   Wed Apr 27 08:06:57 2022 -0600

    Fix libinproctrace.so build on PPC
    
    The recent gnulib import caused a build failure of libinproctrace.so
    on PPC:
    
        alloc.c:(.text+0x20): undefined reference to `rpl_malloc'
        alloc.c:(.text+0x70): undefined reference to `rpl_realloc'
    
    This patch fixes the problem using the same workaround that was
    previously used for free.

Diff:
---
 gdbserver/Makefile.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gdbserver/Makefile.in b/gdbserver/Makefile.in
index b9a687c9231..6e14278cd4b 100644
--- a/gdbserver/Makefile.in
+++ b/gdbserver/Makefile.in
@@ -470,7 +470,8 @@ UST_CFLAGS = $(ustinc) -DCONFIG_UST_GDB_INTEGRATION
 # Undo gnulib replacements for the IPA shared library build.
 # The gnulib headers are still needed, but gnulib is not linked
 # into the IPA lib so replacement apis don't work.
-UNDO_GNULIB_CFLAGS = -Drpl_strerror_r=strerror_r -Drpl_free=free
+UNDO_GNULIB_CFLAGS = -Drpl_strerror_r=strerror_r -Drpl_free=free \
+	-Drpl_malloc=malloc -Drpl_realloc=realloc
 
 # Note, we only build the IPA if -fvisibility=hidden is supported in
 # the first place.


                 reply	other threads:[~2022-04-28 18:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220428185202.0EECD3858405@sourceware.org \
    --to=tromey@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).