From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id AFF6C3857405; Fri, 29 Apr 2022 22:23:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AFF6C3857405 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Convert internal breakpoints to vtable ops X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: 5bd3caf1b2f95139764916e2a6e07a95453b717f X-Git-Newrev: c359fff502a91a31d7369dfab75179a8d8923fb2 Message-Id: <20220429222315.AFF6C3857405@sourceware.org> Date: Fri, 29 Apr 2022 22:23:15 +0000 (GMT) X-BeenThere: gdb-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Apr 2022 22:23:15 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Dc359fff502a9= 1a31d7369dfab75179a8d8923fb2 commit c359fff502a91a31d7369dfab75179a8d8923fb2 Author: Tom Tromey Date: Sat Jan 15 15:23:25 2022 -0700 Convert internal breakpoints to vtable ops =20 This converts internal breakpoints to use vtable_breakpoint_ops. Diff: --- gdb/breakpoint.c | 61 +++++++++++++++++++++++-----------------------------= ---- 1 file changed, 25 insertions(+), 36 deletions(-) diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index ebbad3204d7..ed012d0c9ff 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -234,9 +234,6 @@ static int strace_marker_p (struct breakpoint *b); (user breakpoints, internal and momentary breakpoints, etc.). */ static struct breakpoint_ops bkpt_base_breakpoint_ops; =20 -/* Internal breakpoints class type. */ -static struct breakpoint_ops internal_breakpoint_ops; - /* Momentary breakpoints class type. */ static struct breakpoint_ops momentary_breakpoint_ops; =20 @@ -261,6 +258,10 @@ struct ordinary_breakpoint : public base_breakpoint /* Internal breakpoints. */ struct internal_breakpoint : public base_breakpoint { + void re_set () override; + void check_status (struct bpstat *bs) override; + enum print_stop_action print_it (struct bpstat *bs) override; + void print_mention () override; }; =20 /* Momentary breakpoints. */ @@ -3316,7 +3317,7 @@ create_overlay_event_breakpoint (void) addr =3D bp_objfile_data->overlay_msym.value_address (); b =3D create_internal_breakpoint (objfile->arch (), addr, bp_overlay_event, - &internal_breakpoint_ops); + &vtable_breakpoint_ops); initialize_explicit_location (&explicit_loc); explicit_loc.function_name =3D ASTRDUP (func_name); b->location =3D new_explicit_location (&explicit_loc); @@ -3376,7 +3377,7 @@ create_longjmp_master_breakpoint_probe (objfile *objf= ile) b =3D create_internal_breakpoint (gdbarch, p->get_relocated_address (objfile), bp_longjmp_master, - &internal_breakpoint_ops); + &vtable_breakpoint_ops); b->location =3D new_probe_location ("-probe-stap libc:longjmp"); b->enable_state =3D bp_disabled; } @@ -3425,7 +3426,7 @@ create_longjmp_master_breakpoint_names (objfile *objf= ile) =20 addr =3D bp_objfile_data->longjmp_msym[i].value_address (); b =3D create_internal_breakpoint (gdbarch, addr, bp_longjmp_master, - &internal_breakpoint_ops); + &vtable_breakpoint_ops); initialize_explicit_location (&explicit_loc); explicit_loc.function_name =3D ASTRDUP (func_name); b->location =3D new_explicit_location (&explicit_loc); @@ -3509,7 +3510,7 @@ create_std_terminate_master_breakpoint (void) addr =3D bp_objfile_data->terminate_msym.value_address (); b =3D create_internal_breakpoint (objfile->arch (), addr, bp_std_terminate_master, - &internal_breakpoint_ops); + &vtable_breakpoint_ops); initialize_explicit_location (&explicit_loc); explicit_loc.function_name =3D ASTRDUP (func_name); b->location =3D new_explicit_location (&explicit_loc); @@ -3562,7 +3563,7 @@ create_exception_master_breakpoint_probe (objfile *ob= jfile) b =3D create_internal_breakpoint (gdbarch, p->get_relocated_address (objfile), bp_exception_master, - &internal_breakpoint_ops); + &vtable_breakpoint_ops); b->location =3D new_probe_location ("-probe-stap libgcc:unwind"); b->enable_state =3D bp_disabled; } @@ -3608,7 +3609,7 @@ create_exception_master_breakpoint_hook (objfile *obj= file) addr =3D gdbarch_convert_from_func_ptr_addr (gdbarch, addr, current_inferior ()->top_target ()); b =3D create_internal_breakpoint (gdbarch, addr, bp_exception_master, - &internal_breakpoint_ops); + &vtable_breakpoint_ops); initialize_explicit_location (&explicit_loc); explicit_loc.function_name =3D ASTRDUP (func_name); b->location =3D new_explicit_location (&explicit_loc); @@ -7547,7 +7548,7 @@ create_thread_event_breakpoint (struct gdbarch *gdbar= ch, CORE_ADDR address) struct breakpoint *b; =20 b =3D create_internal_breakpoint (gdbarch, address, bp_thread_event, - &internal_breakpoint_ops); + &vtable_breakpoint_ops); =20 b->enable_state =3D bp_enabled; /* location has to be used or breakpoint_re_set will delete me. */ @@ -7570,7 +7571,7 @@ struct breakpoint * create_jit_event_breakpoint (struct gdbarch *gdbarch, CORE_ADDR address) { return create_internal_breakpoint (gdbarch, address, bp_jit_event, - &internal_breakpoint_ops); + &vtable_breakpoint_ops); } =20 /* Remove JIT code registration and unregistration breakpoint(s). */ @@ -7615,7 +7616,7 @@ create_solib_event_breakpoint_1 (struct gdbarch *gdba= rch, CORE_ADDR address, struct breakpoint *b; =20 b =3D create_internal_breakpoint (gdbarch, address, bp_shlib_event, - &internal_breakpoint_ops); + &vtable_breakpoint_ops); update_global_location_list_nothrow (insert_mode); return b; } @@ -11985,10 +11986,10 @@ base_breakpoint::decode_location (struct event_lo= cation *location, =20 /* Virtual table for internal breakpoints. */ =20 -static void -internal_bkpt_re_set (struct breakpoint *b) +void +internal_breakpoint::re_set () { - switch (b->type) + switch (type) { /* Delete overlay event and longjmp master breakpoints; they will be reset later by breakpoint_re_set. */ @@ -11996,7 +11997,7 @@ internal_bkpt_re_set (struct breakpoint *b) case bp_longjmp_master: case bp_std_terminate_master: case bp_exception_master: - delete_breakpoint (b); + delete_breakpoint (this); break; =20 /* This breakpoint is special, it's set up when the inferior @@ -12010,10 +12011,10 @@ internal_bkpt_re_set (struct breakpoint *b) } } =20 -static void -internal_bkpt_check_status (bpstat *bs) +void +internal_breakpoint::check_status (bpstat *bs) { - if (bs->breakpoint_at->type =3D=3D bp_shlib_event) + if (type =3D=3D bp_shlib_event) { /* If requested, stop when the dynamic linker notifies GDB of events. This allows the user to get control and place @@ -12026,14 +12027,10 @@ internal_bkpt_check_status (bpstat *bs) bs->stop =3D 0; } =20 -static enum print_stop_action -internal_bkpt_print_it (bpstat *bs) +enum print_stop_action +internal_breakpoint::print_it (bpstat *bs) { - struct breakpoint *b; - - b =3D bs->breakpoint_at; - - switch (b->type) + switch (type) { case bp_shlib_event: /* Did we stop because the user set the stop_on_solib_events @@ -12074,8 +12071,8 @@ internal_bkpt_print_it (bpstat *bs) return PRINT_NOTHING; } =20 -static void -internal_bkpt_print_mention (struct breakpoint *b) +void +internal_breakpoint::print_mention () { /* Nothing to mention. These breakpoints are internal. */ } @@ -14583,14 +14580,6 @@ initialize_breakpoint_ops (void) ops->print_mention =3D print_mention_ranged_breakpoint; ops->print_recreate =3D print_recreate_ranged_breakpoint; =20 - /* Internal breakpoints. */ - ops =3D &internal_breakpoint_ops; - *ops =3D bkpt_base_breakpoint_ops; - ops->re_set =3D internal_bkpt_re_set; - ops->check_status =3D internal_bkpt_check_status; - ops->print_it =3D internal_bkpt_print_it; - ops->print_mention =3D internal_bkpt_print_mention; - /* Momentary breakpoints. */ ops =3D &momentary_breakpoint_ops; *ops =3D bkpt_base_breakpoint_ops;