public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Mark Wielaard <mark@sourceware.org> To: bfd-cvs@sourceware.org, gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb: Workaround stringop-overread warning in debuginfod-support.c on s390x Date: Wed, 4 May 2022 14:19:10 +0000 (GMT) [thread overview] Message-ID: <20220504141910.3C3D1385625F@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=716e54731f30bc60b2fc52996ebe4fc087420b2e commit 716e54731f30bc60b2fc52996ebe4fc087420b2e Author: Mark Wielaard <mark@klomp.org> Date: Tue May 3 23:17:31 2022 +0000 gdb: Workaround stringop-overread warning in debuginfod-support.c on s390x For some reason g++ 11.2.1 on s390x produces a spurious warning for stringop-overread in debuginfod_is_enabled for url_view. Add a new DIAGNOSTIC_IGNORE_STRINGOP_OVERREAD macro to suppress this warning. include/ChangeLog: * diagnostics.h (DIAGNOSTIC_IGNORE_STRINGOP_OVERREAD): New macro. gdb/ChangeLog: * debuginfod-support.c (debuginfod_is_enabled): Use DIAGNOSTIC_IGNORE_STRINGOP_OVERREAD on s390x. Diff: --- gdb/debuginfod-support.c | 11 +++++++++++ include/diagnostics.h | 7 +++++++ 2 files changed, 18 insertions(+) diff --git a/gdb/debuginfod-support.c b/gdb/debuginfod-support.c index dffcd782e7d..f2a31ea1952 100644 --- a/gdb/debuginfod-support.c +++ b/gdb/debuginfod-support.c @@ -17,6 +17,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */ #include "defs.h" +#include "diagnostics.h" #include <errno.h> #include "gdbsupport/scoped_fd.h" #include "debuginfod-support.h" @@ -192,7 +193,17 @@ debuginfod_is_enabled () if (off == gdb::string_view::npos) break; url_view = url_view.substr (off); +#if defined (__s390x__) + /* g++ 11.2.1 on s390x seems convinced url_view might be of + SIZE_MAX length. And so complains because the length of + an array can only be PTRDIFF_MAX. */ + DIAGNOSTIC_PUSH + DIAGNOSTIC_IGNORE_STRINGOP_OVERREAD +#endif off = url_view.find_first_of (' '); +#if defined (__s390x__) + DIAGNOSTIC_POP +#endif gdb_printf (_(" <%ps>\n"), styled_string (file_name_style.style (), diff --git a/include/diagnostics.h b/include/diagnostics.h index f10d066150a..8bf5a3c3d9b 100644 --- a/include/diagnostics.h +++ b/include/diagnostics.h @@ -76,6 +76,9 @@ # define DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION \ DIAGNOSTIC_IGNORE ("-Wstringop-truncation") +# define DIAGNOSTIC_IGNORE_STRINGOP_OVERREAD \ + DIAGNOSTIC_IGNORE ("-Wstringop-overread") + # define DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL \ DIAGNOSTIC_IGNORE ("-Wformat-nonliteral") @@ -108,6 +111,10 @@ # define DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION #endif +#ifndef DIAGNOSTIC_IGNORE_STRINGOP_OVERREAD +# define DIAGNOSTIC_IGNORE_STRINGOP_OVERREAD +#endif + #ifndef DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL # define DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL #endif
reply other threads:[~2022-05-04 14:19 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220504141910.3C3D1385625F@sourceware.org \ --to=mark@sourceware.org \ --cc=bfd-cvs@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).