public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Boolify breakpoint::explains_signal Date: Fri, 6 May 2022 18:10:11 +0000 (GMT) [thread overview] Message-ID: <20220506181011.6D764395200F@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a6860f3ad2d0ee89ee8b4a7f257b7fdcac84b5c4 commit a6860f3ad2d0ee89ee8b4a7f257b7fdcac84b5c4 Author: Tom Tromey <tom@tromey.com> Date: Sat Apr 30 08:04:30 2022 -0600 Boolify breakpoint::explains_signal This changes breakpoint::explains_signal to return bool. Diff: --- gdb/break-catch-sig.c | 6 +++--- gdb/breakpoint.c | 6 +++--- gdb/breakpoint.h | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/gdb/break-catch-sig.c b/gdb/break-catch-sig.c index 8f6d3967718..7f73b9e5981 100644 --- a/gdb/break-catch-sig.c +++ b/gdb/break-catch-sig.c @@ -51,7 +51,7 @@ struct signal_catchpoint : public breakpoint bool print_one (struct bp_location **) override; void print_mention () override; void print_recreate (struct ui_file *fp) override; - int explains_signal (enum gdb_signal) override; + bool explains_signal (enum gdb_signal) override; /* Signal numbers used for the 'catch signal' feature. If no signal has been specified for filtering, it is empty. Otherwise, @@ -297,10 +297,10 @@ signal_catchpoint::print_recreate (struct ui_file *fp) /* Implement the "explains_signal" method for signal catchpoints. */ -int +bool signal_catchpoint::explains_signal (enum gdb_signal sig) { - return 1; + return true; } /* Create a new signal catchpoint. TEMPFLAG is true if this should be diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 7e8fae92ffb..2521e95ce70 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -9716,15 +9716,15 @@ watchpoint::print_recreate (struct ui_file *fp) /* Implement the "explains_signal" method for watchpoints. */ -int +bool watchpoint::explains_signal (enum gdb_signal sig) { /* A software watchpoint cannot cause a signal other than GDB_SIGNAL_TRAP. */ if (type == bp_watchpoint && sig != GDB_SIGNAL_TRAP) - return 0; + return false; - return 1; + return true; } struct masked_watchpoint : public watchpoint diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h index b0ca4e98eb4..ec3a8309b51 100644 --- a/gdb/breakpoint.h +++ b/gdb/breakpoint.h @@ -721,9 +721,9 @@ struct breakpoint /* Return true if this breakpoint explains a signal. See bpstat_explains_signal. */ - virtual int explains_signal (enum gdb_signal) + virtual bool explains_signal (enum gdb_signal) { - return 1; + return true; } /* Called after evaluating the breakpoint's condition, @@ -882,7 +882,7 @@ struct watchpoint : public breakpoint enum print_stop_action print_it (struct bpstat *bs) override; void print_mention () override; void print_recreate (struct ui_file *fp) override; - int explains_signal (enum gdb_signal) override; + bool explains_signal (enum gdb_signal) override; /* String form of exp to use for displaying to the user (malloc'd), or NULL if none. */
reply other threads:[~2022-05-06 18:10 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220506181011.6D764395200F@sourceware.org \ --to=tromey@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).