public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Maciej W. Rozycki <macro@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] gdb: mips: Fix large-frame.exp test case failure
Date: Tue, 10 May 2022 21:09:05 +0000 (GMT)	[thread overview]
Message-ID: <20220510210905.1562B3858D33@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f8b786e2eddbbad9e9aa724038feb1ffcf7b2bd9

commit f8b786e2eddbbad9e9aa724038feb1ffcf7b2bd9
Author: Youling Tang <tangyouling@loongson.cn>
Date:   Tue May 10 22:07:04 2022 +0100

    gdb: mips: Fix large-frame.exp test case failure
    
    $ objdump -d outputs/gdb.base/large-frame/large-frame-O2
    0000000120000b20 <func>:
       120000b20:   67bdbff0        daddiu  sp,sp,-16400
       120000b24:   ffbc4000        sd      gp,16384(sp)
       120000b28:   3c1c0002        lui     gp,0x2
       120000b2c:   679c8210        daddiu  gp,gp,-32240
       120000b30:   0399e02d        daddu   gp,gp,t9
       120000b34:   df998058        ld      t9,-32680(gp)
       120000b38:   ffbf4008        sd      ra,16392(sp)
       120000b3c:   0411ffd8        bal     120000aa0 <blah>
    ...
    
    The disassembly of the above func function shows that we may use
    instructions such as daddiu/daddu, so add "daddiu $gp,$gp,n",
    "daddu $gp,$gp,$t9" and "daddu $gp,$t9,$gp" to the mips32_scan_prologue
    function to fix the large-frame.exp test case.
    
    Before applying the patch:
    
     backtrace
     #0  blah (a=0xfffffee220) at .../gdb/testsuite/gdb.base/large-frame-1.c:24
     #1  0x0000000120000b44 in func ()
     Backtrace stopped: frame did not save the PC
     (gdb) FAIL: gdb.base/large-frame.exp: optimize=-O2: backtrace
    
     # of expected passes            5
     # of unexpected failures        1
    
    After applying the patch:
    
     # of expected passes            6
    
    Signed-off-by: Youling Tang <tangyouling@loongson.cn>

Diff:
---
 gdb/mips-tdep.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gdb/mips-tdep.c b/gdb/mips-tdep.c
index ffed8723dce..805c5beba59 100644
--- a/gdb/mips-tdep.c
+++ b/gdb/mips-tdep.c
@@ -3588,8 +3588,11 @@ restart:
 	       || (inst & 0xFF9F07FF) == 0x00800021 /* move reg,$a0-$a3 */
 	       || high_word == 0x3c1c /* lui $gp,n */
 	       || high_word == 0x279c /* addiu $gp,$gp,n */
+	       || high_word == 0x679c /* daddiu $gp,$gp,n */
 	       || inst == 0x0399e021 /* addu $gp,$gp,$t9 */
 	       || inst == 0x033ce021 /* addu $gp,$t9,$gp */
+	       || inst == 0x0399e02d /* daddu $gp,$gp,$t9 */
+	       || inst == 0x033ce02d /* daddu $gp,$t9,$gp */
 	      )
 	{
 	  /* These instructions are part of the prologue, but we don't


                 reply	other threads:[~2022-05-10 21:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220510210905.1562B3858D33@sourceware.org \
    --to=macro@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).