public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] [gdb/record] Handle statx system call Date: Wed, 11 May 2022 06:35:37 +0000 (GMT) [thread overview] Message-ID: <20220511063537.17DD53856247@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d423425393e4ef27cabdda4134ae27905a18fcf7 commit d423425393e4ef27cabdda4134ae27905a18fcf7 Author: Tom de Vries <tdevries@suse.de> Date: Wed May 11 08:35:33 2022 +0200 [gdb/record] Handle statx system call When running test-case gdb.reverse/fstatat-reverse.exp with target board unix/-m32 on openSUSE Tumbleweed, I run into: ... (gdb) PASS: gdb.reverse/fstatat-reverse.exp: set breakpoint at marker2 continue^M Continuing.^M Process record and replay target doesn't support syscall number 383^M Process record: failed to record execution log.^M ^M Program stopped.^M 0xf7fc5555 in __kernel_vsyscall ()^M (gdb) FAIL: gdb.reverse/fstatat-reverse.exp: continue to breakpoint: marker2 ... The problems is that while with native we're trying to record these syscalls (showing strace output): ... openat(AT_FDCWD, "/", O_RDONLY|O_PATH) = 3 newfstatat(3, ".", {st_mode=S_IFDIR|0755, st_size=146, ...}, 0) = 0 ... with unix/-m32 we have instead: ... openat(AT_FDCWD, "/", O_RDONLY|O_PATH) = 3 statx(3, ".", AT_STATX_SYNC_AS_STAT|AT_NO_AUTOMOUNT, STATX_BASIC_STATS, \ {stx_mask=STATX_ALL|STATX_MNT_ID, stx_attributes=STATX_ATTR_MOUNT_ROOT, \ stx_mode=S_IFDIR|0755, stx_size=146, ...}) = 0 ... and statx is not supported. Fix this by adding support for recording syscall statx. Tested on x86_64-linux. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28461 Diff: --- gdb/linux-record.c | 6 ++++++ gdb/linux-record.h | 1 + 2 files changed, 7 insertions(+) diff --git a/gdb/linux-record.c b/gdb/linux-record.c index ea858df59a6..1e8e3c95567 100644 --- a/gdb/linux-record.c +++ b/gdb/linux-record.c @@ -1046,6 +1046,12 @@ Do you want to stop the program?"), return -1; break; + case gdb_sys_statx: + regcache_raw_read_unsigned (regcache, tdep->arg5, &tmpulongest); + if (record_full_arch_list_add_mem ((CORE_ADDR) tmpulongest, 256)) + return -1; + break; + case gdb_sys_uname: if (record_mem_at_reg (regcache, tdep->arg1, tdep->size_old_utsname)) diff --git a/gdb/linux-record.h b/gdb/linux-record.h index 07f0c5a2604..219c67f888d 100644 --- a/gdb/linux-record.h +++ b/gdb/linux-record.h @@ -510,6 +510,7 @@ enum gdb_syscall { gdb_sys_dup3 = 330, gdb_sys_pipe2 = 331, gdb_sys_inotify_init1 = 332, + gdb_sys_statx = 383, gdb_sys_socket = 500, gdb_sys_connect = 501, gdb_sys_accept = 502,
reply other threads:[~2022-05-11 6:35 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220511063537.17DD53856247@sourceware.org \ --to=vries@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).