public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] [gdb/testsuite] Fix gdb.base/catch-syscall.exp without --enable-targets Date: Wed, 11 May 2022 11:30:38 +0000 (GMT) [thread overview] Message-ID: <20220511113038.962ED3858401@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b00d6678f6ef55ef52d79bfd5424d775bba01f0e commit b00d6678f6ef55ef52d79bfd5424d775bba01f0e Author: Tom de Vries <tdevries@suse.de> Date: Wed May 11 13:30:33 2022 +0200 [gdb/testsuite] Fix gdb.base/catch-syscall.exp without --enable-targets When doing a gdb build without --enable-targets, I run into: ... (gdb) UNSUPPORTED: gdb.base/catch-syscall.exp: multiple targets: \ s390:31-bit vs s390:64-bit: set architecture s390:64-bit delete breakpoints^M (gdb) info breakpoints^M No breakpoints or watchpoints.^M (gdb) break -qualified main^M No symbol table is loaded. Use the "file" command.^M Make breakpoint pending on future shared library load? (y or [n]) n^M (gdb) FAIL: gdb.base/catch-syscall.exp: gdb_breakpoint: set breakpoint at main ... The problem is that due to recent commit e21d8399303 ("[gdb/testsuite] Remove target limits in gdb.base/catch-syscall.exp") "clean_restart $binfile" no longer is called at the end of test_catch_syscall_multi_arch. Fix this by moving "clean_restart $binfile" back to test_catch_syscall_multi_arch. Tested on x86_64-linux. Diff: --- gdb/testsuite/gdb.base/catch-syscall.exp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/gdb/testsuite/gdb.base/catch-syscall.exp b/gdb/testsuite/gdb.base/catch-syscall.exp index fed0e7b774c..1260a64270f 100644 --- a/gdb/testsuite/gdb.base/catch-syscall.exp +++ b/gdb/testsuite/gdb.base/catch-syscall.exp @@ -568,7 +568,7 @@ proc test_catch_syscall_with_wrong_args_noxml {} { proc test_catch_syscall_multi_arch_1 { arch1 arch2 syscall1_name syscall2_name syscall_number } { - global decimal binfile + global decimal with_test_prefix "multiple targets: $arch1 vs $arch2" { # We are not interested in loading any binary here, and in @@ -605,12 +605,12 @@ proc test_catch_syscall_multi_arch_1 { gdb_test "catch syscall $syscall_number" \ "Catchpoint $decimal \\(syscall .${syscall2_name}. \\\[${syscall_number}\\\]\\)" \ "insert catch syscall on syscall $syscall_number -- $syscall2_name on $arch2" - - clean_restart $binfile } } proc test_catch_syscall_multi_arch {} { + global binfile + set arch1 "i386" set arch2 "i386:x86-64" set syscall1_name "exit" @@ -650,6 +650,8 @@ proc test_catch_syscall_multi_arch {} { set syscall_number 142 test_catch_syscall_multi_arch_1 $arch1 $arch2 $syscall1_name \ $syscall2_name $syscall_number + + clean_restart $binfile } proc do_syscall_tests_without_xml {} {
reply other threads:[~2022-05-11 11:30 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220511113038.962ED3858401@sourceware.org \ --to=vries@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).