public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] [gdb/testsuite] Fix gdb.cp/break-f-std-string.cc with older gcc Date: Thu, 12 May 2022 12:52:45 +0000 (GMT) [thread overview] Message-ID: <20220512125245.496913839C6C@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c8a9e88bf6ff32d90d082d07d3c5d12b938f8335 commit c8a9e88bf6ff32d90d082d07d3c5d12b938f8335 Author: Tom de Vries <tdevries@suse.de> Date: Thu May 12 14:52:41 2022 +0200 [gdb/testsuite] Fix gdb.cp/break-f-std-string.cc with older gcc When running test-case gdb.cp/break-f-std-string.exp on openSUSE Leap 15.3 with system gcc 7.5.0, I run into: ... (gdb) whatis /r std::string^M No symbol "string" in namespace "std".^M (gdb) FAIL: gdb.cp/break-f-std-string.exp: _GLIBCXX_USE_CXX11_ABI=1: \ whatis /r std::string ... The same for gcc 8.2.1, but it passes with gcc 9.3.1. At source level (as we can observe in the .ii file with -save-temps) we have indeed: ... namespace std { namespace __cxx11 { typedef basic_string<char> string; } } ... while with gcc 9.3.1, we have instead: ... namespace std { namespace __cxx11 { ... } typedef basic_string<char> string; } ... due to gcc commit 33b43b0d8cd ("Define std::string and related typedefs outside __cxx11 namespace"). Fix this by adding the missing typedef for gcc version 5 (the first version to have the dual abi) to 8 (the last version missing aforementioned gcc commit). Tested on x86_64-linux, with: - system gcc 7.5.0 - gcc 4.8.5, 8.2.1, 9.3.1, 10.3.0, 11.2.1 - clang 8.0.1, 12.0.1 Diff: --- gdb/testsuite/gdb.cp/break-f-std-string.cc | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/gdb/testsuite/gdb.cp/break-f-std-string.cc b/gdb/testsuite/gdb.cp/break-f-std-string.cc index 454ab4c42ea..0c361234d82 100644 --- a/gdb/testsuite/gdb.cp/break-f-std-string.cc +++ b/gdb/testsuite/gdb.cp/break-f-std-string.cc @@ -17,6 +17,19 @@ #include <string> +#if _GLIBCXX_USE_CXX11_ABI == 1 +#if defined (__GNUC__) && (__GNUC__ >= 5) && (__GNUC__ <= 8) + +/* Work around missing std::string typedef before gcc commit + "Define std::string and related typedefs outside __cxx11 namespace". */ + +namespace std { +typedef __cxx11::string string; +} + +#endif +#endif + void f (std::string s) {
reply other threads:[~2022-05-12 12:52 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220512125245.496913839C6C@sourceware.org \ --to=vries@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).