public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Fix Ada exception regression on Windows
Date: Mon, 16 May 2022 15:10:12 +0000 (GMT)	[thread overview]
Message-ID: <20220516151012.77990385780F@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1779689128d45ca6fd1d1484f2fd907ac791873e

commit 1779689128d45ca6fd1d1484f2fd907ac791873e
Author: Tom Tromey <tromey@adacore.com>
Date:   Wed May 4 10:28:35 2022 -0600

    Fix Ada exception regression on Windows
    
    The breakpoint c++-ification series introduced another bug in Ada --
    it caused "catch exception" and related commands to fail on Windows.
    The problem is that the re_set method calls the wrong superclass
    method, so the breakpoint doesn't get correctly re-set when the
    runtime offsets change.  This patch fixes the problem.

Diff:
---
 gdb/ada-lang.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index 8333671c48b..248b847cfbc 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -12212,7 +12212,7 @@ ada_catchpoint::re_set ()
 {
   /* Call the base class's method.  This updates the catchpoint's
      locations.  */
-  this->breakpoint::re_set ();
+  this->base_breakpoint::re_set ();
 
   /* Reparse the exception conditional expressions.  One for each
      location.  */


                 reply	other threads:[~2022-05-16 15:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220516151012.77990385780F@sourceware.org \
    --to=tromey@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).