From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7825) id 8B4DA3858C51; Tue, 17 May 2022 10:43:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8B4DA3858C51 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Felix Willgerodt To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb, btrace: Throw an error for empty recordings when replaying starts. X-Act-Checkin: binutils-gdb X-Git-Author: Felix Willgerodt X-Git-Refname: refs/heads/master X-Git-Oldrev: ed01945057cfdf048bc025f15b410492e12283f6 X-Git-Newrev: 49a73ab9d345e1cd412a93b34a0b8c166603d80e Message-Id: <20220517104353.8B4DA3858C51@sourceware.org> Date: Tue, 17 May 2022 10:43:53 +0000 (GMT) X-BeenThere: gdb-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2022 10:43:53 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D49a73ab9d345= e1cd412a93b34a0b8c166603d80e commit 49a73ab9d345e1cd412a93b34a0b8c166603d80e Author: Felix Willgerodt Date: Mon May 9 10:12:39 2022 +0200 gdb, btrace: Throw an error for empty recordings when replaying starts. =20 This makes record_btrace_start_replaying() more consistent, as it alrea= dy errors out e.g. on a recording with only gaps. Diff: --- gdb/record-btrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c index 373d82b8b99..3f8a69dd04f 100644 --- a/gdb/record-btrace.c +++ b/gdb/record-btrace.c @@ -2017,7 +2017,7 @@ record_btrace_start_replaying (struct thread_info *tp) =20 /* We can't start replaying without trace. */ if (btinfo->functions.empty ()) - return NULL; + error (_("No trace.")); =20 /* GDB stores the current frame_id when stepping in order to detects ste= ps into subroutines.