From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vries@sourceware.org>
Received: by sourceware.org (Postfix, from userid 2205)
 id 87AFB3858C53; Wed, 18 May 2022 10:12:33 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 87AFB3858C53
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Use hex_for_lang in
 gdb.base/parse_number.exp
X-Act-Checkin: binutils-gdb
X-Git-Author: Tom de Vries <tdevries@suse.de>
X-Git-Refname: refs/heads/master
X-Git-Oldrev: 192257c998507f8a6ad9a85394b4fd4c627552cb
X-Git-Newrev: 71630188adffa1222ff3341b54700f537e0f2e07
Message-Id: <20220518101233.87AFB3858C53@sourceware.org>
Date: Wed, 18 May 2022 10:12:33 +0000 (GMT)
X-BeenThere: gdb-cvs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-cvs mailing list <gdb-cvs.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-cvs>,
 <mailto:gdb-cvs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-cvs/>
List-Help: <mailto:gdb-cvs-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-cvs>,
 <mailto:gdb-cvs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 18 May 2022 10:12:33 -0000

https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D71630188adff=
a1222ff3341b54700f537e0f2e07

commit 71630188adffa1222ff3341b54700f537e0f2e07
Author: Tom de Vries <tdevries@suse.de>
Date:   Wed May 18 12:12:29 2022 +0200

    [gdb/testsuite] Use hex_for_lang in gdb.base/parse_number.exp
   =20
    In gdb.base/parse_number.exp, add a new proc hex_for_lang that formats =
a hex
    number appropriately for a given language.
   =20
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.base/parse_number.exp | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.base/parse_number.exp b/gdb/testsuite/gdb.ba=
se/parse_number.exp
index ccef3f09655..9668099bd82 100644
--- a/gdb/testsuite/gdb.base/parse_number.exp
+++ b/gdb/testsuite/gdb.base/parse_number.exp
@@ -13,6 +13,18 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
=20
+# Format hex value VAL for language LANG.
+
+proc hex_for_lang { lang val } {
+    set val [regsub ^0x $val ""]
+    if { $lang =3D=3D "modula-2" } {
+       set val 0[string toupper $val]H
+    } else {
+       set val 0x$val
+    }
+    return $val
+}
+
 # Test parsing numbers.  Several language parsers had the same bug
 # around parsing large 64-bit numbers, hitting undefined behavior, and
 # thus crashing a GDB built with UBSan.  This testcase goes over all
@@ -53,11 +65,12 @@ proc test_parse_numbers {arch} {
 	gdb_test_no_output "set language $lang"
=20
 	set val "0xffffffffffffffff"
+	set val [hex_for_lang $lang $val]
 	if {$lang =3D=3D "fortran"} {
 	    gdb_test "p/x $val" " =3D $fortran_value"
 	    gdb_test "ptype $val" " =3D $fortran_type"
 	} elseif {$lang =3D=3D "modula-2"} {
-	    gdb_test "p/x 0FFFFFFFFFFFFFFFFH" "Overflow on numeric constant\\."
+	    gdb_test "p/x $val" "Overflow on numeric constant\\."
 	} elseif {$lang =3D=3D "unknown"} {
 	    gdb_test "p/x $val" \
 		"expression parsing not implemented for language \"Unknown\""