public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Simplify unknown lang testing in gdb.base/parse_number.exp
Date: Wed, 18 May 2022 10:12:38 +0000 (GMT)	[thread overview]
Message-ID: <20220518101238.9858E385803D@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a2ff75485c2db439923450dad90caa25615781ae

commit a2ff75485c2db439923450dad90caa25615781ae
Author: Tom de Vries <tdevries@suse.de>
Date:   Wed May 18 12:12:29 2022 +0200

    [gdb/testsuite] Simplify unknown lang testing in gdb.base/parse_number.exp
    
    Move testing of language unknown out of the $supported_archs loop in
    gdb.base/parse_number.exp.  This reduces total amount of tests from 18466 to
    17744.
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.base/parse_number.exp | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/gdb/testsuite/gdb.base/parse_number.exp b/gdb/testsuite/gdb.base/parse_number.exp
index 9668099bd82..444f5d0534b 100644
--- a/gdb/testsuite/gdb.base/parse_number.exp
+++ b/gdb/testsuite/gdb.base/parse_number.exp
@@ -62,6 +62,10 @@ proc test_parse_numbers {arch} {
     }
 
     foreach_with_prefix lang $::all_languages {
+	if { $lang == "unknown" } {
+	    continue
+	}
+
 	gdb_test_no_output "set language $lang"
 
 	set val "0xffffffffffffffff"
@@ -71,9 +75,6 @@ proc test_parse_numbers {arch} {
 	    gdb_test "ptype $val" " = $fortran_type"
 	} elseif {$lang == "modula-2"} {
 	    gdb_test "p/x $val" "Overflow on numeric constant\\."
-	} elseif {$lang == "unknown"} {
-	    gdb_test "p/x $val" \
-		"expression parsing not implemented for language \"Unknown\""
 	} else {
 	    # D and Rust define their own built-in 64-bit types, and
 	    # are thus always able to parse/print 64-bit values.
@@ -102,6 +103,10 @@ proc test_parse_numbers {arch} {
 
 clean_restart
 
+gdb_test_no_output "set language unknown"
+gdb_test "p/x 0" \
+	"expression parsing not implemented for language \"Unknown\""
+
 gdb_test_no_output "set max-completions unlimited"
 
 set supported_archs [get_set_option_choices "set architecture"]


                 reply	other threads:[~2022-05-18 10:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220518101238.9858E385803D@sourceware.org \
    --to=vries@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).